Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] package/datatables: new package
Date: Sat, 2 Jan 2021 11:55:45 +0100	[thread overview]
Message-ID: <20210102115545.3138feab@windsurf> (raw)
In-Reply-To: <20201208180529.9152-2-patrickdepinguin@gmail.com>

Hello,

On Tue,  8 Dec 2020 19:05:25 +0100
Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote:

> From: Joeri Barbarien <joeri.barbarien@nokia.com>
> 
> Signed-off-by: Joeri Barbarien <joeri.barbarien@nokia.com>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Thanks, applied, with one change. See below.

> +DATATABLES_VERSION = 1.10.20
> +DATATABLES_SITE = https://datatables.net/releases
> +DATATABLES_SOURCE =  DataTables-$(DATATABLES_VERSION).zip
> +DATATABLES_LICENSE = MIT
> +DATATABLES_LICENSE_FILES = DataTables-$(DATATABLES_VERSION)/license.txt
> +
> +define DATATABLES_EXTRACT_CMDS
> +	$(UNZIP) $(DATATABLES_DL_DIR)/$(DATATABLES_SOURCE) -d $(@D)
> +endef
> +
> +define DATATABLES_INSTALL_TARGET_CMDS
> +	$(INSTALL) -m 0755 -d $(TARGET_DIR)/var/www/datatables/css $(TARGET_DIR)/var/www/datatables/js
> +	$(INSTALL) -m 0644 -t $(TARGET_DIR)/var/www/datatables/css $(@D)/DataTables-$(DATATABLES_VERSION)/media/css/*.min.css
> +	$(INSTALL) -m 0644 -t $(TARGET_DIR)/var/www/datatables/js $(@D)/DataTables-$(DATATABLES_VERSION)/media/js/*.min.js
> +endef

I've changed EXTRACT_CMDS to move files directly into $(@D):

+define DATATABLES_EXTRACT_CMDS
+       $(UNZIP) $(DATATABLES_DL_DIR)/$(DATATABLES_SOURCE) -d $(@D)
+       mv $(@D)/DataTables-$(DATATABLES_VERSION)/* $(@D)
+       rmdir $(@D)/DataTables-$(DATATABLES_VERSION)
+endef

We typically do that in other packages that use .zip files as sources.
It avoids the need for using $(@D)/DataTables-$(DATATABLES_VERSION)
everywhere.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2021-01-02 10:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 18:05 [Buildroot] [PATCH 1/5] package/jszip: new package Thomas De Schampheleire
2020-12-08 18:05 ` [Buildroot] [PATCH 2/5] package/datatables: " Thomas De Schampheleire
2021-01-02 10:55   ` Thomas Petazzoni [this message]
2020-12-08 18:05 ` [Buildroot] [PATCH 3/5] package/datatables-buttons: " Thomas De Schampheleire
2021-01-02 11:06   ` Thomas Petazzoni
2020-12-08 18:05 ` [Buildroot] [PATCH 4/5] package/datatables-fixedcolumns: " Thomas De Schampheleire
2021-01-02 11:22   ` Thomas Petazzoni
2020-12-08 18:05 ` [Buildroot] [PATCH 5/5] package/datatables-responsive: " Thomas De Schampheleire
2021-01-02 11:25   ` Thomas Petazzoni
2021-01-02 10:33 ` [Buildroot] [PATCH 1/5] package/jszip: " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210102115545.3138feab@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox