From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/nfs-utils: select BR2_PACKAGE_RPCBIND only if needed
Date: Sun, 3 Jan 2021 12:43:58 +0100 [thread overview]
Message-ID: <20210103114358.GN2997@scaer> (raw)
In-Reply-To: <20201116114033.844188-1-angelo@amarulasolutions.com>
Angelo, All,
On 2020-11-16 12:40 +0100, Angelo Compagnucci spake thusly:
> rpcbind is only used by nfsd to export nfs share supporting older
> v2, v3 protocols.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
> package/nfs-utils/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/nfs-utils/Config.in b/package/nfs-utils/Config.in
> index cfca034019..36d799486a 100644
> --- a/package/nfs-utils/Config.in
> +++ b/package/nfs-utils/Config.in
> @@ -7,7 +7,7 @@ config BR2_PACKAGE_NFS_UTILS
> depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind
> depends on BR2_USE_MMU # fork()
> select BR2_PACKAGE_LIBTIRPC # IPv6 requires libtirpc
> - select BR2_PACKAGE_RPCBIND # runtime
> + select BR2_PACKAGE_RPCBIND if BR2_PACKAGE_NFS_UTILS_RPC_NFSD # runtime# runtime
Then why is the select not moved to the BR2_PACKAGE_NFS_UTILS_RPC_NFSD
symbol itself?
Also, duplicated comment...
Applied to master with the above fixed, thanks.
Regards,
Yann E. MORIN.
> help
> The NFS Linux kernel server.
>
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-01-03 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 11:40 [Buildroot] [PATCH] package/nfs-utils: select BR2_PACKAGE_RPCBIND only if needed Angelo Compagnucci
2021-01-03 11:43 ` Yann E. MORIN [this message]
2021-01-05 22:28 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210103114358.GN2997@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox