From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/uclibc: add backtrace support option
Date: Sat, 9 Jan 2021 19:03:19 +0100 [thread overview]
Message-ID: <20210109180319.GA3037565@scaer> (raw)
In-Reply-To: <20210109161900.51824-1-andrea.ricchi@amarulasolutions.com>
Andrea, All,
On 2021-01-09 17:19 +0100, Andrea Ricchi spake thusly:
> Add toolchain configuration to support execinfo.h and backtrace
> features.
Thanks for your contribution; see comments below...
> Signed-off-by: Andrea Ricchi <andrea.ricchi@amarulasolutions.com>
> ---
> package/uclibc/Config.in | 7 +++++++
> package/uclibc/uclibc.mk | 11 +++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
> index e59fef3c69..fa3abc2f50 100644
> --- a/package/uclibc/Config.in
> +++ b/package/uclibc/Config.in
> @@ -39,6 +39,13 @@ config BR2_TOOLCHAIN_BUILDROOT_LOCALE
> Enable this option if you want your toolchain to support
> localization and internationalization.
>
> +config BR2_TOOLCHAIN_BUILDROOT_BACKTRACE
> + bool "Enable backtrace support"
> + select BR2_USE_BACKTRACE
There is no such symbol in Buildroot.
Also, backtrace in uClibc-ng depends on support for shared libraries:
https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/extra/Configs/Config.in#n2286
Can you have a further look and resend a fixed-up patch, please?
Also, we do have a standalone package that provides libbacktrace, and
which was not added so long ago. Does that package not provide what you
need?
Regards,
Yann E. MORIN.
> + help
> + Enable this option if you want your toolchain to support
> + execinfo.h and backtrace features.
> +
> choice
> prompt "Thread library implementation"
> help
> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index 53983e852d..b6f6c0f824 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -359,6 +359,16 @@ else
> UCLIBC_SHARED_LIBS_CONFIG = $(call KCONFIG_ENABLE_OPT,HAVE_SHARED)
> endif
>
> +#
> +# backtrace support
> +#
> +
> +ifeq ($(BR2_TOOLCHAIN_BUILDROOT_BACKTRACE),y)
> +UCLIBC_BACKTRACE_CONFIG = $(call KCONFIG_ENABLE_OPT,UCLIBC_HAS_BACKTRACE)
> +else
> +UCLIBC_BACKTRACE_CONFIG = $(call KCONFIG_DISABLE_OPT,UCLIBC_HAS_BACKTRACE)
> +endif
> +
> #
> # Commands
> #
> @@ -401,6 +411,7 @@ define UCLIBC_KCONFIG_FIXUP_CMDS
> $(UCLIBC_LOCALE_CONFIG)
> $(UCLIBC_WCHAR_CONFIG)
> $(UCLIBC_SHARED_LIBS_CONFIG)
> + $(UCLIBC_BACKTRACE_CONFIG)
> endef
>
> define UCLIBC_BUILD_CMDS
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-01-09 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 16:19 [Buildroot] [PATCH 1/1] package/uclibc: add backtrace support option Andrea Ricchi
2021-01-09 18:03 ` Yann E. MORIN [this message]
2021-01-09 18:11 ` Yann E. MORIN
2021-01-11 10:46 ` Andrea Ricchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210109180319.GA3037565@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox