From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 9 Jan 2021 21:14:24 +0100 Subject: [Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR In-Reply-To: <874kjqxi53.fsf@dell.be.48ers.dk> References: <20210108175300.537545-1-fontaine.fabrice@gmail.com> <874kjqxi53.fsf@dell.be.48ers.dk> Message-ID: <20210109211424.11091067@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Sat, 09 Jan 2021 16:08:24 +0100 Peter Korsgaard wrote: > > +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME) > > I am not sure why we do this obfuscation with the _NAME variable instead > of just "openvpn" - But ok, a bunch of other packages do so as well. Yes, it was done like this in the original patch from Matt, and I kept it as-is, but I also wasn't too sure about it. But since nobody complained when I posted the patch, I applied it as-is. I definitely wouldn't oppose to changing this to not use the _NAME variable, as it find this indirection to not be very useful. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com