Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] fs/cpio: add zstd as compression option
Date: Sat, 16 Jan 2021 23:00:44 +0100	[thread overview]
Message-ID: <20210116230044.219ee827@windsurf.home> (raw)
In-Reply-To: <20210110190559.1434055-1-salvador.joseluis@gmail.com>

Hello,

On Sun, 10 Jan 2021 20:05:59 +0100
Jos? Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:

> U-Boot mkimage zstd is available since v2020.10:
> https://gitlab.denx.de/u-boot/u-boot/-/commit/26073f9ed3ab0aaf3c2a2b433fecb30a95a067d6
> 
> Signed-off-by: Jos? Luis Salvador Rufo <salvador.joseluis@gmail.com>

Thanks, I have applied, with one change, see below.

> ---
>  fs/common.mk      | 5 +++++
>  fs/cpio/Config.in | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/fs/common.mk b/fs/common.mk
> index 84e13d1b7e..da008ef9e8 100644
> --- a/fs/common.mk
> +++ b/fs/common.mk
> @@ -154,6 +154,11 @@ ifeq ($(BR2_REPRODUCIBLE),)
>  ROOTFS_$(2)_COMPRESS_CMD += -T $(PARALLEL_JOBS)
>  endif
>  endif
> +ifeq ($(BR2_TARGET_ROOTFS_$(2)_ZSTD),y)
> +ROOTFS_$(2)_DEPENDENCIES += host-zstd
> +ROOTFS_$(2)_COMPRESS_EXT = .zst
> +ROOTFS_$(2)_COMPRESS_CMD = zstd --ultra -22 -z -f -T$(PARALLEL_JOBS)

To me, it felt a bit extreme to use the --ultra -22 level, which is
documented as requiring a lot of memory, both for compression and
uncompression. So I changed to just -19 instead.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2021-01-16 22:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10  4:38 [Buildroot] [PATCH 1/1] fs/cpio: add zstd as compression option José Luis Salvador Rufo
2021-01-10 11:12 ` Yann E. MORIN
2021-01-10 19:05   ` [Buildroot] [PATCH v2] " José Luis Salvador Rufo
2021-01-16 22:00     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210116230044.219ee827@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox