Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/ssdp-responder: new package
Date: Sun, 24 Jan 2021 23:33:30 +0100	[thread overview]
Message-ID: <20210124223330.GL2325@scaer> (raw)
In-Reply-To: <20210124194908.1762833-2-troglobit@gmail.com>

Joachim, All,

On 2021-01-24 20:49 +0100, Joachim Wiberg spake thusly:
> Small (35k), and stand-alone, SSDP responder with built-in web server
> (on port 1901) for serving description.xml when Windows scans for any
> network devices on the LAN.  Also includes ssdp-scan (31k), similar to
> the mdns-scan tool, to probe for SSDP capable devices.
> 
> Verified with check-package and test-pkg, no-mmu builds disabled.

I've done a bit of research as to why noMMU builds were broken.

Initially, you stated:
> +	depends on BR2_USE_MMU # fork()

However, ssdp-responder does not use fork().

So I was a bit surprised, and spawned a test build, and indeed it fails,
but for very obscur reasons. In that situation, a lot of functions, even
very basic ones, like strdup(), do not get prototyped, and a lot of
multicast-related structs, like struct ip_mreq, do not get defined.

I tried to dig the root cause, but I lost too much hair, so I bailed out
and comitted your patch as is, just with the fork() reference dropped.

Applied to master, thanks.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-01-24 22:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-23 23:15 [Buildroot] [PATCH 1/1] package/ssdp-responder: new package Joachim Wiberg
2021-01-24  9:51 ` Yann E. MORIN
2021-01-24 15:36   ` Joachim Wiberg
2021-01-24 19:49   ` [Buildroot] [PATCH v2 0/1] " Joachim Wiberg
2021-01-24 19:49     ` [Buildroot] [PATCH v2 1/1] " Joachim Wiberg
2021-01-24 22:33       ` Yann E. MORIN [this message]
2021-01-24 23:36         ` Joachim Wiberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210124223330.GL2325@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox