Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error
Date: Mon, 25 Jan 2021 22:15:37 +0100	[thread overview]
Message-ID: <20210125221537.5cb4dbdd@windsurf.home> (raw)
In-Reply-To: <20210125145742.42460-1-matthew.weber@rockwellcollins.com>

On Mon, 25 Jan 2021 08:57:41 -0600
Matt Weber <matthew.weber@rockwellcollins.com> wrote:

> From: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
> 
> If Target u-boot is not available, the host build of uboot-tools
> requires user to provide u-boot environment source file.
> This change resolves a missing parentheses and updates the comment
> for the same.
> 
> Signed-off-by: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
>  package/uboot-tools/uboot-tools.mk | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks. I think this bug really shows we need some
unit tests for this uboot-tools package functionality, in
supporting/testing/.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2021-01-25 21:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 14:57 [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error Matt Weber
2021-01-25 14:57 ` [Buildroot] [PATCH 2/2] package/uboot-tools: env/script generation need BINARIES_DIR Matt Weber
2021-01-25 21:16   ` Thomas Petazzoni
2021-01-25 21:22     ` Matthew Weber
2021-01-25 21:42       ` Yann E. MORIN
2021-01-25 22:22         ` Thomas Petazzoni
2021-01-26 13:09           ` [Buildroot] [External] " Matthew Weber
2021-01-25 21:15 ` Thomas Petazzoni [this message]
2021-01-25 21:30   ` [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error Matthew Weber
2021-01-25 21:37     ` Thomas Petazzoni
2021-01-28 18:32 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125221537.5cb4dbdd@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox