[Buildroot] [PATCH] package/refpolicy: do not use the bare target in the configuration step

[Yann E. MORIN <yann.morin.1998@free.fr>]

Antoine, All,

On 2021-02-11 09:51 +0100, Antoine Tenart spake thusly:
> Quoting Yann E. MORIN (2021-02-10 21:47:59)
> > On 2021-02-10 19:51 +0100, Antoine Tenart spake thusly:
> > > The 'bare' target is a clean target, removing generated files from
> > > previous builds. Here in Buildroot we'll only build the refpolicy from a
> > > clean state and we don't need to execute this target. Remove it.
> > 
> > Will that still do correct builds with 'make refpolicy-rebuild' ?
> 
> I think you meant refpolicy-reconfigure, as I don't think rebuild will
> call the configuration step again.

Yes, of course. ;-)

> I double checked and there's an issue with an use case; the list of
> modules to compile is not updated if a module is deleted (if added,
> yes...). While we shouldn't expect much when deleting something from a
> package (as the installation step will not clean what was installed
> before),

Well, it can happen if one is using on a custom policy and working on it
with REFPOLICY_OVERRIDE_SRCDIR: the source files may change, appear, or
disappear between two builds...

> here, as we're explicitly using the monolithic build, removing
> a module and reconfiguring should work. So let's be safe and keep this
> as is.

So I've marked this patch as rejected in patchwork, then. Thanks for the
prompt feedback!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'