Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH-NEXT 2/4] package/linux-firmware.mk: get rid of temporary tarball for file installation
Date: Fri, 12 Feb 2021 19:40:47 +0100	[thread overview]
Message-ID: <20210212184049.13202-3-peter@korsgaard.com> (raw)
In-Reply-To: <20210212184049.13202-1-peter@korsgaard.com>

With the upcoming addition of the images-install step,
LINUX_FIRMWARE_INSTALl_FILES is called twice, for installing to the target
and to the images directory - Which may race with each other and cause
problems with the temporary install.tar tarball.

There is no specific reason to use a temporary file, we can just as well
pipe the two tar invocations together, so do that instead.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/linux-firmware/linux-firmware.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
index 3420266335..b6549ad371 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -641,8 +641,8 @@ endif
 ifneq ($(LINUX_FIRMWARE_FILES),)
 define LINUX_FIRMWARE_INSTALL_FILES
 	cd $(@D) && \
-		$(TAR) cf install.tar $(sort $(LINUX_FIRMWARE_FILES)) && \
-		$(TAR) xf install.tar -C $(1)
+		$(TAR) c $(sort $(LINUX_FIRMWARE_FILES)) | \
+		$(TAR) x -C $(1)
 endef
 endif
 
-- 
2.20.1

  parent reply	other threads:[~2021-02-12 18:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 18:40 [Buildroot] [PATCH-NEXT 0/4] package/linux-firmware: install into images for early loading support Peter Korsgaard
2021-02-12 18:40 ` [Buildroot] [PATCH-NEXT 1/4] package/linux-firmware: make target install macros accept a destination parameter Peter Korsgaard
2021-02-12 18:40 ` Peter Korsgaard [this message]
2021-02-12 20:39   ` [Buildroot] [PATCH-NEXT 2/4] package/linux-firmware.mk: get rid of temporary tarball for file installation Yann E. MORIN
2021-02-12 21:07     ` Yann E. MORIN
2021-02-13  8:35       ` Yann E. MORIN
2021-02-13  9:46         ` Peter Korsgaard
2021-02-13 10:05           ` Yann E. MORIN
2021-02-12 21:37     ` Peter Korsgaard
2021-02-13  8:37       ` Yann E. MORIN
2021-02-13  9:47         ` Peter Korsgaard
2021-02-13  9:51           ` Yann E. MORIN
2021-02-13 10:14             ` Peter Korsgaard
2021-02-13 10:19               ` Yann E. MORIN
2021-02-13 10:26                 ` Peter Korsgaard
2021-02-12 18:40 ` [Buildroot] [PATCH-NEXT 3/4] package/linux-firmware: also install into images for early loading support Peter Korsgaard
2021-02-12 18:40 ` [Buildroot] [PATCH-NEXT 4/4] linux: build after linux-firmware if enabled " Peter Korsgaard
2021-02-13 10:13   ` Yann E. MORIN
2021-02-13 10:32     ` Peter Korsgaard
2021-02-13 13:26       ` Yann E. MORIN
2021-02-13 15:24         ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210212184049.13202-3-peter@korsgaard.com \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox