Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/tzdata: bump version to 2020f
Date: Mon, 15 Feb 2021 01:01:09 +0100	[thread overview]
Message-ID: <20210215000109.GI6798@piout.net> (raw)
In-Reply-To: <20210214203543.GA2945341@scaer>

On 14/02/2021 21:35:43+0100, Yann E. MORIN wrote:
> On 2021-02-14 19:35 +0100, Romain Naour spake thusly:
> > Le 14/02/2021 ? 19:21, Alexandre Belloni a ?crit?:
> > > On 14/02/2021 17:34:47+0100, Peter Korsgaard wrote:
> > >> Ok, thanks. There was a report on IRC that timezones on uClibc were
> > >> broken as well because of an incompatibility between the new tzdata
> > >> files and tzdump.
> > > No, the issue is with zic that is not generating proper Tzif2 files (the
> > > tzif2 header is there twice).
> > The issue happen on Glibc toolchain.
> 
> The issues *also* happends on uClibc toolchains (as reported on IRC),
> and I suspect it also happens on musl toolchains (as it uses the same
> tzdata and zic as for glibc).
> 
> And Alexandre investigated quickly a few days ago, and reported on IRC
> (quoting):
> 
> 01:01 < abelloni> mcon: temporary workaround, you can revert 7868289fd53480201f8be7b72097246b7923611c.
> 01:02 < abelloni> y_morin: ^
> 01:02 < abelloni> y_morin: since the bump the zic output has two TZif2 headers, this breaks tzdump
> 01:03 < abelloni> maybe this also break glibc, I didn't check yet
> 
> So it looks like the duplicated header is causing issues everywhere...
> 
> > I added back the previous default zic format "fat" instead of "slim" [1] to pass
> > the test. The default format has been changed in 2020b release.
> > I'm not sure if we should keep the "fat" format...
> > [1] https://github.com/eggert/tz/commit/6ba6f2117b95eab345a7ed9159cef939e30c4cd3
> 
> From this, it looks like the 'fat' format is not 2038-safe, while the
> 'slim' one is.
> 
> To be noted: the glibc version used in thoses tests is 2.18, released in
> August 2013...
> 
> It seems the support for the slim format was only introduced with glibc
> 2.32. 2.31 has no mention of either slim or fat, while 2.32 mention
> both, as it synced with upstream tz 2020a; the previous sync was with
> 2018i...
> 
> So, what I suggest we do:
> 
>   - for master (and next): revert to fat for external glibc, use slim
>     for internal glibc (check for c-sky)
> 
>   - for maintenance branches: unconditionally revert to fat.
> 
> Thoughts?
> 

I'll add that tzdump probably needs to be rewritten (or fixing but a
rewrite is probably better) to handle the slim format, until then, you'd
have to use the fat format for uclibc.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2021-02-15  0:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10 16:47 [Buildroot] [PATCH 1/2] package/zic: bump version to 2020f Bernd Kuhls
2021-01-10 16:47 ` [Buildroot] [PATCH 2/2] package/tzdata: " Bernd Kuhls
2021-01-12 17:40   ` Peter Korsgaard
2021-02-14 15:06     ` Romain Naour
2021-02-14 15:30       ` Peter Korsgaard
2021-02-14 15:44         ` Romain Naour
2021-02-14 16:34           ` Peter Korsgaard
2021-02-14 18:21             ` Alexandre Belloni
2021-02-14 18:35               ` Romain Naour
2021-02-14 20:35                 ` Yann E. MORIN
2021-02-14 21:32                   ` Romain Naour
2021-02-15  0:01                   ` Alexandre Belloni [this message]
2021-02-15  9:12                     ` Peter Korsgaard
2021-02-15  9:12                   ` Peter Korsgaard
2021-02-15  9:34                     ` Romain Naour
2021-02-15 11:02                       ` Peter Korsgaard
2021-01-10 18:34 ` [Buildroot] [PATCH 1/2] package/zic: " Yann E. MORIN
2021-01-12 17:40 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210215000109.GI6798@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox