From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/cegui: override first _CONF_OPTS instead of appending
Date: Fri, 19 Feb 2021 22:48:57 +0100 [thread overview]
Message-ID: <20210219214857.GH2276@scaer> (raw)
In-Reply-To: <20210218175905.9837-1-b.bilas@grinn-global.com>
Bartosz, All,
On 2021-02-18 18:59 +0100, Bartosz Bilas spake thusly:
> During the package update, there was a mistake
> and we appended the options to the first CONF_OPTS
> variable instead of overriding it.
> Fix that by removing an append-assignment.
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
Applied to master, thanks, with the following tweaks;
- reference the exact commit that introduce the issue
- also move the first item to its own line
Regards,
Yann E. MORIN.
> ---
> package/cegui/cegui.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
> index 23919e0151..0596d6566b 100644
> --- a/package/cegui/cegui.mk
> +++ b/package/cegui/cegui.mk
> @@ -9,7 +9,7 @@ CEGUI_SITE = $(call github,cegui,cegui,v$(CEGUI_VERSION))
> CEGUI_LICENSE = MIT
> CEGUI_LICENSE_FILES = COPYING
> CEGUI_INSTALL_STAGING = YES
> -CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_XERCES=OFF \
> +CEGUI_CONF_OPTS = -DCEGUI_BUILD_XMLPARSER_XERCES=OFF \
> -DCEGUI_HAS_MINIZIP_RESOURCE_PROVIDER=OFF \
> -DCEGUI_BUILD_RENDERER_OGRE=OFF
> CEGUI_DEPENDENCIES = glm \
> --
> 2.30.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-02-19 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 17:59 [Buildroot] [PATCH] package/cegui: override first _CONF_OPTS instead of appending Bartosz Bilas
2021-02-19 21:48 ` Yann E. MORIN [this message]
2021-02-27 17:58 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219214857.GH2276@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox