From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files
Date: Sat, 20 Feb 2021 23:20:54 +0100 [thread overview]
Message-ID: <20210220222054.GU2276@scaer> (raw)
In-Reply-To: <20210220162715.283519-1-fancp2007@gmail.com>
Scott, All,
On 2021-02-21 00:27 +0800, Scott Fan spake thusly:
> Signed-off-by: Scott Fan <fancp2007@gmail.com>
> ---
> package/open62541/open62541.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/open62541/open62541.mk b/package/open62541/open62541.mk
> index 5a9f27562a..65742e83a1 100644
> --- a/package/open62541/open62541.mk
> +++ b/package/open62541/open62541.mk
> @@ -54,4 +54,11 @@ else
> OPEN62541_CONF_OPTS += -DUA_ENABLE_PUBSUB_INFORMATIONMODEL=OFF
> endif
>
> +# Remove unneeded files
> +define OPEN62541_REMOVE_UNNEEDED_FILES
> + $(RM) -r $(TARGET_DIR)/usr/share/open62541
Are you sure that we want to remove the whole dorectory? There are some
tools in there that look like they might be useful.
But hte whole directory is indeed 52MiB, with 51 for the 'ua-nodeset'
alone (whatever that is), so maybe we do indeed need to do some cleanup.
So, could you please respin this patch:
- if really nothing is needed in that directory, then remove
everything liek you did, but extend the commit log to explain why
nothing in there is required,
- if there are stuff that can be useful at runtime, then rework the
hook to be a bit more selective in what it removes.
Regards,
Yann E. MORIN.
> +endef
> +
> +OPEN62541_POST_INSTALL_TARGET_HOOKS += OPEN62541_REMOVE_UNNEEDED_FILES
> +
> $(eval $(cmake-package))
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-02-20 22:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 16:27 [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files Scott Fan
2021-02-20 16:27 ` [Buildroot] [PATCH 2/3] package/open62541: fix library version definition Scott Fan
2021-02-20 22:13 ` Yann E. MORIN
2021-02-20 16:27 ` [Buildroot] [PATCH 3/3] package/open62541: bump version to 1.2 Scott Fan
2021-03-16 21:41 ` Thomas Petazzoni
2021-03-20 4:02 ` Scott Fan
2021-03-24 0:22 ` Scott Fan
2021-02-20 22:20 ` Yann E. MORIN [this message]
2021-02-22 5:39 ` [Buildroot] [PATCH] package/open62541: cleanup tools files after installation Scott Fan
2021-03-16 22:16 ` Thomas Petazzoni
2021-03-17 10:33 ` Yann Cardaillac
2021-07-25 21:58 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210220222054.GU2276@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox