From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/download/svn: fix date format for archive creation
Date: Mon, 22 Feb 2021 23:06:01 +0100 [thread overview]
Message-ID: <20210222220601.GH2276@scaer> (raw)
In-Reply-To: <20210219212154.27107-1-vfazio@xes-inc.com>
Vincent, All,
On 2021-02-19 15:21 -0600, Vincent Fazio spake thusly:
> Previously we would use the date provided by:
> `svn info --show-item last-changed-date ...`
>
> The date returned from this command could include sub-second precision
> which is not compatible with the PAX options we specify to GNU tar.
>
> Now the returned date is massaged to drop the sub-seconds.
>
> Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
In the end, I did move it to the helper, because:
- this really is an internal detail on a limitation of the PAX format,
- we do not really mind what exact timestamp goes in the archive, as
long as it is reproducible.
Also, as suggested by Arnout, I switched to usig an explicit date-time
POSIX-compliant format string, rather than rely on -Iseconds, which is
a GNU extension.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> support/download/svn | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/support/download/svn b/support/download/svn
> index 839dccaf62..ea1032267f 100755
> --- a/support/download/svn
> +++ b/support/download/svn
> @@ -52,6 +52,9 @@ _svn export ${verbose} "${@}" "'${uri}@${rev}'" "'${basename}'"
> # last line (svn outputs everything on stdout)
> date="$( _svn info --show-item last-changed-date "'${uri}@${rev}'" |tail -n 1 )"
>
> +# Drop sub-second precision to play nice with GNU tar's valid_timespec check
> +date="$( date -d "${date}" -uIseconds )"
> +
> # Generate the archive.
> # We did a 'svn export' above, so it's not a working copy (there is no .svn
> # directory or file to ignore).
> --
> 2.30.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2021-02-22 22:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 21:21 [Buildroot] [PATCH] support/download/svn: fix date format for archive creation Vincent Fazio
2021-02-20 9:51 ` Yann E. MORIN
2021-02-22 10:58 ` Arnout Vandecappelle
2021-02-22 18:28 ` Yann E. MORIN
2021-02-22 20:14 ` Yann E. MORIN
2021-02-22 22:06 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222220601.GH2276@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox