Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 1/2] package/batman-adv: fix compile with BR2_PACKAGE_BATMAN_ADV_BATMAN_V disabled
Date: Mon, 15 Mar 2021 20:53:27 +0100	[thread overview]
Message-ID: <20210315195327.GR2737665@scaer> (raw)
In-Reply-To: <20210314223207.13460-1-ps.report@gmx.net>

Peter, All,

On 2021-03-14 23:32 +0100, Peter Seiderer spake thusly:
> The given 'CONFIG_BATMAN_ADV_BATMAN_V=' is enough to trigger the wrong
> code compile path in net/batman-adv/bat_v.h missing the static inline
> dummy implementations.
> 
> Fixes:
> 
>   ERROR: modpost: "batadv_v_mesh_free" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
>   ERROR: modpost: "batadv_v_mesh_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
>   ERROR: modpost: "batadv_v_hardif_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
>   ERROR: modpost: "batadv_v_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/batman-adv/batman-adv.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/batman-adv/batman-adv.mk b/package/batman-adv/batman-adv.mk
> index bd648b5a6c..0b9fcaefc0 100644
> --- a/package/batman-adv/batman-adv.mk
> +++ b/package/batman-adv/batman-adv.mk
> @@ -20,12 +20,12 @@ BATMAN_ADV_MODULE_MAKE_OPTS = \
>  	INSTALL_MOD_DIR=updates/net/batman-adv \
>  	NOSTDINC_FLAGS="$(BATMAN_ADV_CFLAGS)" \
>  	CONFIG_BATMAN_ADV=m \
> -	CONFIG_BATMAN_ADV_BATMAN_V=$(BR2_PACKAGE_BATMAN_ADV_BATMAN_V) \
> +	$(if $(BR2_PACKAGE_BATMAN_ADV_BATMAN_V), CONFIG_BATMAN_ADV_BATMAN_V=y) \
>  	CONFIG_BATMAN_ADV_BLA=y \
>  	CONFIG_BATMAN_ADV_DAT=y \
> -	CONFIG_BATMAN_ADV_DEBUG=$(BR2_PACKAGE_BATMAN_ADV_DEBUG) \
> +	$(if $(BR2_PACKAGE_BATMAN_ADV_DEBUG), CONFIG_BATMAN_ADV_DEBUG=y) \
>  	CONFIG_BATMAN_ADV_MCAST=y \
> -	CONFIG_BATMAN_ADV_NC=$(BR2_PACKAGE_BATMAN_ADV_NC)
> +	$(if $(BR2_PACKAGE_BATMAN_ADV_NC), CONFIG_BATMAN_ADV_NC=y)
>  BATMAN_ADV_MODULE_SUBDIRS = net/batman-adv
>  
>  define BATMAN_ADV_CONFIGURE_CMDS
> -- 
> 2.30.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2021-03-15 19:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-14 22:32 [Buildroot] [PATCH v1 1/2] package/batman-adv: fix compile with BR2_PACKAGE_BATMAN_ADV_BATMAN_V disabled Peter Seiderer
2021-03-14 22:32 ` [Buildroot] [PATCH v1 2/2] package/batman-adv: enable B.A.T.M.A.N. V protocol by default Peter Seiderer
2021-03-15 19:59   ` Yann E. MORIN
2021-03-15 20:49     ` Christian Stewart
2021-03-15 22:12     ` Peter Seiderer
2022-07-24 21:26   ` Arnout Vandecappelle
2021-03-15 19:53 ` Yann E. MORIN [this message]
2021-03-15 21:00 ` [Buildroot] [PATCH v1 1/2] package/batman-adv: fix compile with BR2_PACKAGE_BATMAN_ADV_BATMAN_V disabled Christian Stewart
2021-03-15 21:50   ` Peter Seiderer
2021-03-16  1:45     ` Christian Stewart
2021-03-16 18:19       ` Peter Seiderer
2021-03-23 17:26 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315195327.GR2737665@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox