From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] package/haveged: bump version to 1.9.14
Date: Tue, 30 Mar 2021 22:39:21 +0200 [thread overview]
Message-ID: <20210330223921.5bd7beba@gmx.net> (raw)
In-Reply-To: <20210330222326.5ef6482e@windsurf.home>
Hello Thomas,
On Tue, 30 Mar 2021 22:23:26 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello Peter,
>
> Thanks for this patch!
>
> On Sun, 21 Mar 2021 21:59:08 +0100
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > - change to set all available configure options:
> >
> > * '--enable-daemon=yes': previous default
> >
> > * '--enable-diagnostic=no': previous default
> >
> > * '-enable-init=no': do not install init files as buildroot ships its
> > own sysv/systemd init files
> >
> > * '--enable-nistest=no': disable tests, previous default
> >
> > * '--enable-enttest=no': new option, disable tests
> >
> > * '--enable-olt=no': previous default was yes, disable builtin test
> >
> > * '--enable-tune=yes': previous default
>
> Do you have any reason for using --enable-<foo>=yes/no instead of the
> standard --enable-<foo> / --disable-<foo> we use everywhere in
> Buildroot ?
No special reason other than following the style of the one pre-existent
option in haveged.mk (see [1])...
But will test the enable/disable style and re-iterate the patch...
>
> > +# patch touchign configure.ac
>
> ^^ minor typo
Ups..., will fix it...
>
> (I would have fixed myself, but I have the other question
> enable/disable options).
Regards,
Peter
[1] https://git.buildroot.net/buildroot/tree/package/haveged/haveged.mk#n14
>
> Thanks!
>
> Thomas
prev parent reply other threads:[~2021-03-30 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 20:59 [Buildroot] [PATCH v1] package/haveged: bump version to 1.9.14 Peter Seiderer
2021-03-21 21:11 ` Peter Seiderer
2021-03-30 20:23 ` Thomas Petazzoni
2021-03-30 20:39 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330223921.5bd7beba@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox