From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/qpid-proton: fix build without threads
Date: Fri, 2 Apr 2021 23:54:11 +0200 [thread overview]
Message-ID: <20210402215411.GL24043@scaer> (raw)
In-Reply-To: <20210402163343.1254491-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2021-04-02 18:33 +0200, Fabrice Fontaine spake thusly:
> Build of qpid-proton is broken since bump to version 0.33.0 in commit
> d4c0fde91da0d79204a21ed8de1bd410efa1c4d6 because epoll proactor
> unconditonally uses pthread
>
> Fixes:
> - http://autobuild.buildroot.org/results/ec34da16a11f0600ecfbbbc4039e8210aea0498c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/qpid-proton/qpid-proton.mk b/package/qpid-proton/qpid-proton.mk
> index b73ab8d6da..bbf953c472 100644
> --- a/package/qpid-proton/qpid-proton.mk
> +++ b/package/qpid-proton/qpid-proton.mk
> @@ -31,6 +31,14 @@ QPID_PROTON_CONF_OPTS = \
> -DENABLE_WARNING_ERROR=OFF \
> -DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python2
>
> +# epoll proactor unconditionally uses pthread and cpp binding unconditionally
> +# uses proactor
I added a small clarification that 'CPP' in this context means C++, not
cpp. Ain't it confusing? ;-)
Applied to master, thanks.
Regards,
Yann E. MORIN.
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
> +QPID_PROTON_CONF_OPTS += \
> + -DBUILD_CPP=OFF \
> + -DPROACTOR=none
> +endif
> +
> ifeq ($(BR2_PACKAGE_JSONCPP),y)
> QPID_PROTON_DEPENDENCIES += jsoncpp
> QPID_PROTON_CONF_OPTS += -DENABLE_JSONCPP=ON
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2021-04-02 21:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 16:33 [Buildroot] [PATCH 1/3] package/qpid-proton: fix build without threads Fabrice Fontaine
2021-04-02 16:33 ` [Buildroot] [PATCH 2/3] package/pkg-cmake.mk: don't unconditionally set CMAKE_CXX_COMPILER Fabrice Fontaine
2021-04-02 21:52 ` Yann E. MORIN
2021-04-04 9:27 ` Peter Korsgaard
2021-04-02 16:33 ` [Buildroot] [PATCH 3/3] package/qpid-proton: fix build without C++ Fabrice Fontaine
2021-04-02 21:54 ` Yann E. MORIN
2021-04-02 21:54 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402215411.GL24043@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox