From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Sat, 3 Apr 2021 16:52:21 +0200
Subject: [Buildroot] [PATCH 1/1] package/cifs-utils: add missing python
 dependencies
In-Reply-To: <20210403132349.2220750-1-fontaine.fabrice@gmail.com>
References: <20210403132349.2220750-1-fontaine.fabrice@gmail.com>
Message-ID: <20210403145221.GA2252@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Fabrice, All,

On 2021-04-03 15:23 +0200, Fabrice Fontaine spake thusly:
> Add missing python dependencies which have been forgotten when bumping
> to version 6.12 in commit b5dede7d1a03ab2b8caa0a8e79b09c8df6c62fe4
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/acdbf7c58ec8ae648f8048bc75650dcdcdca6285
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/cifs-utils/Config.in | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/cifs-utils/Config.in b/package/cifs-utils/Config.in
> index 0e61243de4..55829e3dc2 100644
> --- a/package/cifs-utils/Config.in
> +++ b/package/cifs-utils/Config.in
> @@ -18,9 +18,16 @@ if BR2_PACKAGE_CIFS_UTILS
>  
>  config BR2_PACKAGE_CIFS_UTILS_SMBTOOLS
>  	bool "smbtools"
> +	depends on BR2_USE_WCHAR # python
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # python
> +	depends on !BR2_STATIC_LIBS # python

We select python3, not python, so the added dependencies are because of
python3, not python.

Comments fixed accordingly, and patch applied to master, thanks.

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON # runtime
>  	help
>  	  Install the smb tools smbinfo and smb2-quota (python
>  	  implementations).
>  
> +comment "smbtools needs a toolchain w/ wchar, threads, dynamic library"
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
> +		BR2_STATIC_LIBS
> +
>  endif
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'