From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/cifs-utils: add missing python dependencies
Date: Mon, 5 Apr 2021 23:08:10 +0200 [thread overview]
Message-ID: <20210405230810.78ad41b4@gmx.net> (raw)
In-Reply-To: <20210403145221.GA2252@scaer>
Hello Fabrice, Yann,
On Sat, 3 Apr 2021 16:52:21 +0200, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Fabrice, All,
>
> On 2021-04-03 15:23 +0200, Fabrice Fontaine spake thusly:
> > Add missing python dependencies which have been forgotten when bumping
> > to version 6.12 in commit b5dede7d1a03ab2b8caa0a8e79b09c8df6c62fe4
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/acdbf7c58ec8ae648f8048bc75650dcdcdca6285
This autobuild failure points to an libffi error...., quick search of the last
autobuild mails did not show an an cifs-utils error (or I did not find it), which
failure is this commit fixing?
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/cifs-utils/Config.in | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/package/cifs-utils/Config.in b/package/cifs-utils/Config.in
> > index 0e61243de4..55829e3dc2 100644
> > --- a/package/cifs-utils/Config.in
> > +++ b/package/cifs-utils/Config.in
> > @@ -18,9 +18,16 @@ if BR2_PACKAGE_CIFS_UTILS
> >
> > config BR2_PACKAGE_CIFS_UTILS_SMBTOOLS
> > bool "smbtools"
> > + depends on BR2_USE_WCHAR # python
> > + depends on BR2_TOOLCHAIN_HAS_THREADS # python
> > + depends on !BR2_STATIC_LIBS # python
>
> We select python3, not python, so the added dependencies are because of
> python3, not python.
>
> Comments fixed accordingly, and patch applied to master, thanks.
>
> Regards,
> Yann E. MORIN.
>
> > select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON # runtime
If this commit is fixing an error (and there is a build time dependency on
python) than, this comment 'runtime' is no longer valid...
Regards,
Peter
> > help
> > Install the smb tools smbinfo and smb2-quota (python
> > implementations).
> >
> > +comment "smbtools needs a toolchain w/ wchar, threads, dynamic library"
> > + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
> > + BR2_STATIC_LIBS
> > +
> > endif
> > --
> > 2.30.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
next prev parent reply other threads:[~2021-04-05 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 13:23 [Buildroot] [PATCH 1/1] package/cifs-utils: add missing python dependencies Fabrice Fontaine
2021-04-03 14:52 ` Yann E. MORIN
2021-04-05 21:08 ` Peter Seiderer [this message]
2021-04-05 21:24 ` Fabrice Fontaine
2021-04-05 22:06 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210405230810.78ad41b4@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox