* [Buildroot] [PATCH 1/1] package/libdrm: fix -Dman-pages=false syntax
@ 2021-04-16 7:27 James Hilliard
2021-04-16 16:52 ` Peter Seiderer
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: James Hilliard @ 2021-04-16 7:27 UTC (permalink / raw)
To: buildroot
The current -Dmanpages=false syntax is invalid.
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/libdrm/libdrm.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libdrm/libdrm.mk b/package/libdrm/libdrm.mk
index 98e1ac079d..f5b205bb00 100644
--- a/package/libdrm/libdrm.mk
+++ b/package/libdrm/libdrm.mk
@@ -17,7 +17,7 @@ LIBDRM_DEPENDENCIES = \
LIBDRM_CONF_OPTS = \
-Dcairo-tests=false \
- -Dmanpages=false
+ -Dman-pages=false
ifeq ($(BR2_PACKAGE_LIBATOMIC_OPS),y)
LIBDRM_DEPENDENCIES += libatomic_ops
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] package/libdrm: fix -Dman-pages=false syntax
2021-04-16 7:27 [Buildroot] [PATCH 1/1] package/libdrm: fix -Dman-pages=false syntax James Hilliard
@ 2021-04-16 16:52 ` Peter Seiderer
2021-04-17 7:06 ` Yann E. MORIN
2021-04-26 7:08 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Seiderer @ 2021-04-16 16:52 UTC (permalink / raw)
To: buildroot
Hello James,
On Fri, 16 Apr 2021 01:27:39 -0600, James Hilliard <james.hilliard1@gmail.com> wrote:
> The current -Dmanpages=false syntax is invalid.
Only one minor nitpick, the failure is not about the syntax but about
the wrong option name, a subject line as
fix man page disable option
would be better...
Fixes:
WARNING: Unknown options: "manpages"
Thanks for fixing my mistake ;-)
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/libdrm/libdrm.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libdrm/libdrm.mk b/package/libdrm/libdrm.mk
> index 98e1ac079d..f5b205bb00 100644
> --- a/package/libdrm/libdrm.mk
> +++ b/package/libdrm/libdrm.mk
> @@ -17,7 +17,7 @@ LIBDRM_DEPENDENCIES = \
>
> LIBDRM_CONF_OPTS = \
> -Dcairo-tests=false \
> - -Dmanpages=false
> + -Dman-pages=false
>
> ifeq ($(BR2_PACKAGE_LIBATOMIC_OPS),y)
> LIBDRM_DEPENDENCIES += libatomic_ops
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/libdrm: fix -Dman-pages=false syntax
2021-04-16 7:27 [Buildroot] [PATCH 1/1] package/libdrm: fix -Dman-pages=false syntax James Hilliard
2021-04-16 16:52 ` Peter Seiderer
@ 2021-04-17 7:06 ` Yann E. MORIN
2021-04-26 7:08 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2021-04-17 7:06 UTC (permalink / raw)
To: buildroot
James, All,
On 2021-04-16 01:27 -0600, James Hilliard spake thusly:
> The current -Dmanpages=false syntax is invalid.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Applied to master, after rewording the commit log as per Peter's
suggestions, thanks.
Regards,
Yann E. MORIN.
> ---
> package/libdrm/libdrm.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libdrm/libdrm.mk b/package/libdrm/libdrm.mk
> index 98e1ac079d..f5b205bb00 100644
> --- a/package/libdrm/libdrm.mk
> +++ b/package/libdrm/libdrm.mk
> @@ -17,7 +17,7 @@ LIBDRM_DEPENDENCIES = \
>
> LIBDRM_CONF_OPTS = \
> -Dcairo-tests=false \
> - -Dmanpages=false
> + -Dman-pages=false
>
> ifeq ($(BR2_PACKAGE_LIBATOMIC_OPS),y)
> LIBDRM_DEPENDENCIES += libatomic_ops
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/libdrm: fix -Dman-pages=false syntax
2021-04-16 7:27 [Buildroot] [PATCH 1/1] package/libdrm: fix -Dman-pages=false syntax James Hilliard
2021-04-16 16:52 ` Peter Seiderer
2021-04-17 7:06 ` Yann E. MORIN
@ 2021-04-26 7:08 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2021-04-26 7:08 UTC (permalink / raw)
To: buildroot
>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:
> The current -Dmanpages=false syntax is invalid.
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Committed to 2021.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-26 7:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-16 7:27 [Buildroot] [PATCH 1/1] package/libdrm: fix -Dman-pages=false syntax James Hilliard
2021-04-16 16:52 ` Peter Seiderer
2021-04-17 7:06 ` Yann E. MORIN
2021-04-26 7:08 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox