From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/bash: drop SHOBJ_STATUS from BASH_CONF_ENV
Date: Sat, 24 Apr 2021 09:46:23 +0200 [thread overview]
Message-ID: <20210424074623.GN298901@scaer> (raw)
In-Reply-To: <20210423202356.37681-3-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2021-04-23 22:23 +0200, Thomas Petazzoni spake thusly:
> SHOBJ_STATUS=unsupported was added in commit
> 4a2af11cba83ef176672609dd7321712fa7f6a28 to work around a limitation
> of the configure script that forgot to set this variable in
> static-linking configurations.
>
> It turns out that this issue has been fixed upstream as of bash 5.0:
>
> https://git.savannah.gnu.org/cgit/bash.git/diff/configure.ac?id=d233b485e83c3a784b803fb894280773f16f2deb
>
> (see hunk @@ -1151,6 +1179,9 @@)
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Baruch Siach <baruch@tkos.co.il>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/bash/bash.mk | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/package/bash/bash.mk b/package/bash/bash.mk
> index 6913ccafd8..7b853ece08 100644
> --- a/package/bash/bash.mk
> +++ b/package/bash/bash.mk
> @@ -29,7 +29,6 @@ BASH_CONF_ENV += \
> # The static build needs some trickery
> ifeq ($(BR2_STATIC_LIBS),y)
> BASH_CONF_OPTS += --enable-static-link
> -BASH_CONF_ENV += SHOBJ_STATUS=unsupported
> # bash wants to redefine the getenv() function. To check whether this is
> # possible, AC_TRY_RUN is used which is not possible in
> # cross-compilation.
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-04-24 7:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 20:23 [Buildroot] [PATCH 1/3] package/bash: use --bindir instead of exec_prefix= Thomas Petazzoni
2021-04-23 20:23 ` [Buildroot] [PATCH 2/3] package/bash: add option to keep or remove loadable examples Thomas Petazzoni
2021-04-24 7:47 ` Yann E. MORIN
2021-04-24 9:25 ` Thomas Petazzoni
2021-04-23 20:23 ` [Buildroot] [PATCH 3/3] package/bash: drop SHOBJ_STATUS from BASH_CONF_ENV Thomas Petazzoni
2021-04-24 7:46 ` Yann E. MORIN [this message]
2021-04-26 19:08 ` Peter Korsgaard
2021-04-24 7:46 ` [Buildroot] [PATCH 1/3] package/bash: use --bindir instead of exec_prefix= Yann E. MORIN
2021-04-26 19:02 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210424074623.GN298901@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox