[Buildroot] boot/grub2: grub-core-build-fixes-for-i386 (grub-2.04 + binutils-2.35.2 + pseudo-op .code64)

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Mikhail,

On Tue, 20 Apr 2021 12:35:16 +0300
"Mikhail B. WproxyM" <w.proxy.m@gmail.com> wrote:

> We are using binutils-2.35.2+ (later then 2.29.1), grub-2.04,
> cross-compiling on recent buildroot under i386/i686 and getting error:
> 
> > lib/i386/relocator64.S:66: Error: unknown pseudo-op: `.code64'  
> 
> So, the working patch is attached. Please add it to buildroot.

Do you have some details on the conditions to reproduce this issue?
Indeed, I just tried to build grub2, with the following configuration:

BR2_x86_core2=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
# BR2_TARGET_ROOTFS_TAR is not set
BR2_TARGET_GRUB2=y
BR2_TARGET_GRUB2_I386_EFI=y

So it's using a i686 target system, with a toolchain that uses binutils
2.34 (i.e later than the 2.29 you're pointing). And it builds fine,
including relocator64.S, which gets built as part of the build process.

Note: I am building *from* an x86-64 system. But how can that matter,
as relocator64.S is built using the cross-compiler?

Also, why isn't this patch in upstream Grub ?

Thanks a lot for the additional details you could provide.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com