From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/dmalloc: unconditionally set -fPIC
Date: Sat, 15 May 2021 17:08:59 +0200 [thread overview]
Message-ID: <20210515150859.GN2506@scaer> (raw)
In-Reply-To: <20210514212602.2274195-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2021-05-14 23:26 +0200, Fabrice Fontaine spake thusly:
> Unconditionally set -fPIC to avoid the following build failure which is
> raised since commit 19ec872f169a851b48ba04d22432b7c0939847d4:
>
> /home/giuliobenetti/autobuild/run/instance-2/output-1/host/bin/or1k-linux-ld -shared --whole-archive -soname libdmallocxx.so -o libdmallocxx.so.t libdmallocxx.a
> /home/giuliobenetti/autobuild/run/instance-2/output-1/host/bin/or1k-linux-ld: libdmallocxx.a(arg_check.o): non-pic relocation against symbol _dmalloc_flags
> /home/giuliobenetti/autobuild/run/instance-2/output-1/host/bin/or1k-linux-ld: libdmallocxx.a(arg_check.o): non-pic relocation against symbol _dmalloc_flags
> /home/giuliobenetti/autobuild/run/instance-2/output-1/host/bin/or1k-linux-ld: libdmallocxx.a(arg_check.o): pc-relative relocation against dynamic symbol dmalloc_verify_pnt
>
> Fixes:
> - http://autobuild.buildroot.org/results/62c9c6aebca60649bd6f635125507bf10d63fc05
I don't think this is the correct fix.
Indeed, that build has BR2_STATIC_LIBS=y so we are supposed to only
build static libs, not shared ones.
Yet, dmalloc is attempting a shared build;
/home/giuliobenetti/autobuild/run/instance-2/output-1/host/bin/or1k-linux-ld
-shared --whole-archive -soname libdmallocxx.so -o libdmallocxx.so.t
libdmallocxx.a
That's because we have an unconditional:
DMALLOC_CONF_OPTS = --enable-shlib
which I guess should be changed to being conditional to !BR2_STATIC_LIBS
Care to look into that, please?
Regards,
Yann E. MORIN.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/dmalloc/dmalloc.mk | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/package/dmalloc/dmalloc.mk b/package/dmalloc/dmalloc.mk
> index 638fe0fcda..8300cc7f19 100644
> --- a/package/dmalloc/dmalloc.mk
> +++ b/package/dmalloc/dmalloc.mk
> @@ -14,11 +14,7 @@ DMALLOC_LICENSE_FILES = dmalloc.h.1
>
> DMALLOC_INSTALL_STAGING = YES
> DMALLOC_CONF_OPTS = --enable-shlib
> -DMALLOC_CFLAGS = $(TARGET_CFLAGS)
> -
> -ifeq ($(BR2_STATIC_LIBS),)
> -DMALLOC_CFLAGS += -fPIC
> -endif
> +DMALLOC_CFLAGS = $(TARGET_CFLAGS) -fPIC
>
> ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
> DMALLOC_CONF_OPTS += --enable-cxx
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2021-05-15 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 21:26 [Buildroot] [PATCH 1/1] package/dmalloc: unconditionally set -fPIC Fabrice Fontaine
2021-05-15 15:08 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210515150859.GN2506@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox