Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 4/4] lmbench: lat_rpc: fix stray pointer
Date: Mon, 17 May 2021 22:09:58 +0200	[thread overview]
Message-ID: <20210517200958.GF2506@scaer> (raw)
In-Reply-To: <20210510180049.61421-6-vgupta@synopsys.com>

Vineet, All,

On 2021-05-10 11:00 -0700, Vineet Gupta via buildroot spake thusly:
> | # ./lat_rpc -S localhost
> | potentially unexpected fatal signal 11.
> | Path: /lmbench/bin/arc64/lat_rpc
> | CPU: 0 PID: 62 Comm: lat_rpc Not tainted 5.6.0-00224-g8e1b159f529e #39
> | Invalid Read @ 0x00000001 by insn @ 0x2011f110
> |   @off 0x6c110 in [/lib/libc-2.32.so]  VMA: 0x200b3000 to 0x201b8000
> | ECR: 0x00050100 EFA: 0x00000001 ERET: 0x2011f110
> | STAT32: 0x80081082 [IE U     ]   BTA: 0x2011b87c
> |  SP: 0x5fffefe8  FP: 0x00000000 BLK: 0x20103242
> | r00: 0x00000001 r01: 0x00000002 r02: 0x00000001
> | r03: 0x20101eb0 r04: 0x00000001 r05: 0x00000001
> | r06: 0x00000000 r07: 0x00000000 r08: 0x00000001
> | r09: 0x2019d8b0 r10: 0x20039fc4 r11: 0x5ffff0f0
> | r12: 0x2019d6d0 r13: 0x2019d748 r14: 0x5ffff588
> | r15: 0x00000000 r16: 0x00000000 r17: 0x5ffff708
> | r18: 0x20039fc0 r19: 0xffffffff r20: 0x201ba010
> | r21: 0x00000000 r22: 0x00000000 r23: 0x20039fc0
> | r24: 0x00000bd0 r25: 0x00000073
> Segmentation fault
> 
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>

Applied to master, thanks.

I was going to suggest sending those patches upstream to lmbench,
but.... It's dead, Jim.

Regards,
Yann E. MORIN.

> ---
>  ...bage-pointer-for-lat_rpc-S-localhost.patch | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 package/lmbench/0004-Fix-garbage-pointer-for-lat_rpc-S-localhost.patch
> 
> diff --git a/package/lmbench/0004-Fix-garbage-pointer-for-lat_rpc-S-localhost.patch b/package/lmbench/0004-Fix-garbage-pointer-for-lat_rpc-S-localhost.patch
> new file mode 100644
> index 000000000000..619ec3861463
> --- /dev/null
> +++ b/package/lmbench/0004-Fix-garbage-pointer-for-lat_rpc-S-localhost.patch
> @@ -0,0 +1,25 @@
> +From 3830453a06269912d2772fe8c31bae44f27bb131 Mon Sep 17 00:00:00 2001
> +From: Vineet Gupta <vgupta@synopsys.com>
> +Date: Fri, 8 May 2015 11:35:58 +0530
> +Subject: [PATCH] Fix garbage pointer for lat_rpc -S localhost
> +
> +Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> +---
> + src/lat_rpc.c | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/src/lat_rpc.c b/src/lat_rpc.c
> +index 9c021926d761..ff4380ff38f3 100644
> +--- a/src/lat_rpc.c
> ++++ b/src/lat_rpc.c
> +@@ -101,6 +101,7 @@ main(int ac, char **av)
> + 	char	*usage = "-s\n OR [-p <tcp|udp>] [-P parallel] [-W <warmup>] [-N <repetitions>] serverhost\n OR -S serverhost\n";
> + 
> + 	state.msize = 1;
> ++	state.server = NULL;
> + 
> + 	while (( c = getopt(ac, av, "sS:m:p:P:W:N:")) != EOF) {
> + 		switch(c) {
> +-- 
> +2.25.1
> +
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-05-17 20:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 18:00 [Buildroot] [PATCH v3 0/4] Updates for ARC, LMBench Vineet Gupta
2021-05-10 18:00 ` [Buildroot] [PATCH v3 1/4] ARC: config: explicit'ify -mcpu for cpu selection Vineet Gupta
2021-05-17 19:24   ` Yann E. MORIN
2021-05-10 18:00 ` [Buildroot] [PATCH v2 2/3] lmbench: increase memsize delay for slow FPGAs Vineet Gupta
2021-05-10 18:00 ` [Buildroot] [PATCH v3 2/4] lmbench: memsize: increase " Vineet Gupta
2021-05-17 20:09   ` Yann E. MORIN
2021-05-17 21:53     ` Vineet Gupta
2021-05-18  6:38       ` Yann E. MORIN
2021-05-20  8:41   ` Peter Korsgaard
2021-05-10 18:00 ` [Buildroot] [PATCH v3 3/4] lmbench: emulate --prefix to avoid scattering binaries all over Vineet Gupta
2021-05-10 20:09   ` Thomas Petazzoni
2021-05-10 20:22     ` Vineet Gupta
2021-05-17 16:59       ` Yann E. MORIN
2021-05-10 18:00 ` [Buildroot] [PATCH v3 4/4] lmbench: lat_rpc: fix stray pointer Vineet Gupta
2021-05-17 20:09   ` Yann E. MORIN [this message]
2021-05-20  8:41   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210517200958.GF2506@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox