From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/waylandpp: add dependency to BR2_INSTALL_LIBSTDCPP
Date: Fri, 21 May 2021 11:35:55 +0200 [thread overview]
Message-ID: <20210521093555.GH3208066@scaer> (raw)
In-Reply-To: <20210521091403.29209-1-heiko.thiery@gmail.com>
Heiko, All,
On 2021-05-21 11:14 +0200, Heiko Thiery spake thusly:
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> package/waylandpp/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/waylandpp/Config.in b/package/waylandpp/Config.in
> index 3d7362b3c0..86ca965056 100644
> --- a/package/waylandpp/Config.in
> +++ b/package/waylandpp/Config.in
> @@ -3,14 +3,16 @@ config BR2_PACKAGE_WAYLANDPP
> depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND
> depends on BR2_HOST_GCC_AT_LEAST_4_9
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + depends on BR2_INSTALL_LIBSTDCPP
You forgot to propagate that dependency to packages that select
waylandpp, namely kodi, so I've done that and applied to master,
thanks.
Regards,
Yann E. MORIN.
> depends on BR2_PACKAGE_WAYLAND
> help
> Wayland C++ bindings
>
> https://github.com/NilsBrause/waylandpp
>
> -comment "waylandpp needs an OpenGL-EGL/wayland backend, a toolchain w/ gcc >= 4.9, host gcc >= 4.9"
> +comment "waylandpp needs an OpenGL-EGL/wayland backend, a toolchain w/ gcc >= 4.9, host gcc >= 4.9, C++ support"
> depends on BR2_PACKAGE_WAYLAND
> depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
> !BR2_HOST_GCC_AT_LEAST_4_9 || \
> - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
> + !BR2_INSTALL_LIBSTDCPP
> --
> 2.30.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-05-21 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 9:14 [Buildroot] [PATCH] package/waylandpp: add dependency to BR2_INSTALL_LIBSTDCPP Heiko Thiery
2021-05-21 9:35 ` Yann E. MORIN [this message]
2021-06-07 21:19 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521093555.GH3208066@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox