From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Fri, 28 May 2021 13:39:59 +0200 Subject: [Buildroot] [PATCH] package/nginx: fix NGINX pidfile handling systemd In-Reply-To: References: <20210521144149.35725-1-matthew.weber@collins.com> <20210526204856.GP3208066@scaer> Message-ID: <20210528113959.GB2788252@scaer> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, All, On 2021-05-27 22:49 +0200, Arnout Vandecappelle spake thusly: > On 26/05/2021 22:48, Yann E. MORIN wrote: > > On 2021-05-21 09:41 -0500, Matthew Weber via buildroot spake thusly: > >> Upstream bug: (deferred fix) > >> https://trac.nginx.org/nginx/ticket/1897?cversion=0&cnum_hist=2 > > So, basically, upstream refused to fix that bug [...] [--SNIP--] > > If so, maybe we could then tweak the unit to make use of it, instead of > > the sleep workaround? > I think there was one useful comment on the Ubuntu bug [1]: > >>> > As far as I can tell, this daemonization is not needed for the systemd service > use-case. The service should be Type=simple, and 'daemon off'. The standard file > handles get redirected by systemd anyway, and non-stop upgrade cannot be used in > this case either. (See: > http://nginx.org/en/docs/faq/daemon_master_process_off.html ) > <<< > So I rather think we should go for that solution. Indeed, that seems an even better solution, and probably an actual fix. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'