From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/pkg-meson: handle b_pie
Date: Sat, 29 May 2021 11:21:41 +0200 [thread overview]
Message-ID: <20210529092141.GO2788252@scaer> (raw)
In-Reply-To: <20210529090943.GM2788252@scaer>
Fabrice, All,
On 2021-05-29 11:09 +0200, Yann E. MORIN spake thusly:
> On 2021-05-28 21:17 +0200, Fabrice Fontaine spake thusly:
> > pipewire unconditionally enables b_pie since version 0.3.20 and
> > https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/abe73c9146cd223b40b22581b1fd58bc044c671e
> > which will raise the following build failure on m68k since commit
> > a6d88d3ba5e30e11f4d726f341bc56c1be7c71c9:
> >
> > /srv/storage/autobuild/run/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/m68k-buildroot-linux-uclibc/9.3.0/../../../../m68k-buildroot-linux-uclibc/bin/ld: /srv/storage/autobuild/run/instance-1/output-1/host/m68k-buildroot-linux-uclibc/sysroot/usr/lib/Scrt1.o: in function `lib_main':
> > (.text+0x4): undefined reference to `__shared_flat_add_library'
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/c258a2736661af8ea73abeda2503d8682e65f1e2
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/pkg-meson.mk | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
> > index a57820d4d2..a55063d58e 100644
> > --- a/package/pkg-meson.mk
> > +++ b/package/pkg-meson.mk
> > @@ -91,6 +91,7 @@ define $(2)_CONFIGURE_CMDS
> > --default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
> > --buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \
> > --cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \
> > + -Db_pie=$(if $(BR2_TOOLCHAIN_SUPPORTS_PIE),true,false) \
[--SNIP--]
> In the meantime, I think it is still correct to have b_pie on the
> command line for our infra, like we have strip, so: applied to master,
> thanks.
Given a later patch that arrived in parallel, it turns out this patch
was not correct, and that we still have a bit of interrogation on that,
so I've reverted it, sorry. I'll keep an eye on the discussions...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-05-29 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 19:17 [Buildroot] [PATCH 1/1] package/pkg-meson: handle b_pie Fabrice Fontaine
2021-05-29 9:09 ` Yann E. MORIN
2021-05-29 9:21 ` Yann E. MORIN [this message]
2021-05-29 9:41 ` Fabrice Fontaine
2021-05-29 19:30 ` Yann E. MORIN
2021-06-01 19:31 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210529092141.GO2788252@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox