From: Adrian Perez de Castro <aperez@igalia.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libsoup: always disable tls_check
Date: Thu, 10 Jun 2021 06:36:27 +0300 [thread overview]
Message-ID: <20210610063627.GD135851@momiji> (raw)
In-Reply-To: <20210609212503.1580411-1-fontaine.fabrice@gmail.com>
Hi,
On Wed, 09 Jun 2021 23:25:03 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Always disable tls_check to avoid the following build failure since bump to
> version 2.72.0 in commit 8e5f7f1cfc8fd7a9d5270f6a9707eb9eecfd21da:
>
> ../output-1/build/libsoup-2.72.0/meson.build:184:4: ERROR: Can not run test applications in this cross environment.
>
> tls_check will run code since
> https://gitlab.gnome.org/GNOME/libsoup/-/commit/5c45253243a2deca4880d4f614f2932373445cf9
I wonder how this check passed locally when doing test builds of the update
before submitting the patch (I did a few cross-builds targeting 64-bit ARM)
?\_(?)_/?
At any rate, it's good to disable the test unconditionally.
> Fixes:
> - http://autobuild.buildroot.org/results/9e539dc7185cfb81f18438dd36357cb49ef23a5a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/libsoup/libsoup.mk | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/libsoup/libsoup.mk b/package/libsoup/libsoup.mk
> index 2f63e9e85c..73c8c080c5 100644
> --- a/package/libsoup/libsoup.mk
> +++ b/package/libsoup/libsoup.mk
> @@ -30,6 +30,7 @@ LIBSOUP_CONF_OPTS = \
> -Dntlm=disabled \
> -Dsysprof=disabled \
> -Dtests=false \
> + -Dtls_check=false \
> -Dvapi=disabled
>
> ifeq ($(BR2_PACKAGE_BROTLI),y)
> @@ -54,8 +55,6 @@ endif
>
> ifeq ($(BR2_PACKAGE_LIBSOUP_SSL),y)
> LIBSOUP_DEPENDENCIES += glib-networking
> -else
> -LIBSOUP_CONF_OPTS += -Dtls_check=false
> endif
>
> $(eval $(meson-package))
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210610/d1b01539/attachment.asc>
next prev parent reply other threads:[~2021-06-10 3:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 21:25 [Buildroot] [PATCH 1/1] package/libsoup: always disable tls_check Fabrice Fontaine
2021-06-10 3:36 ` Adrian Perez de Castro [this message]
2021-06-10 5:34 ` Fabrice Fontaine
2021-06-10 13:21 ` Adrian Perez de Castro
2021-06-10 13:39 ` Fabrice Fontaine
2021-06-10 14:11 ` Adrian Perez de Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610063627.GD135851@momiji \
--to=aperez@igalia.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox