Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/weston: disable -NDEBUG
Date: Wed, 16 Jun 2021 22:09:03 +0200	[thread overview]
Message-ID: <20210616200903.GS2610983@scaer> (raw)
In-Reply-To: <CADvTj4rXx_bo5vQbv83UUQhh3KvmbyUWV4e16v-bO1C5GHxZFA@mail.gmail.com>

James, All,

On 2021-06-16 13:48 -0600, James Hilliard spake thusly:
> On Wed, Jun 16, 2021 at 1:22 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2021-06-14 18:55 -0600, James Hilliard spake thusly:
> > > Fixes:
> > > http://autobuild.buildroot.net/results/f42/f420890de1b52786f8cf5f2922b69c909162eaa1/
> >
> > It is just tests that can't be built with -DNDEBUG. It would be a shame
> > to have to build the whole thing without NDEBUG, just becuase of tests
> > that are not usefull on the target...
> Per upstream weston should not be built with -DNDEBUG since
> weston relies on asserts for non-tests as well to catch certain fatal
> conditions.

That info should have been in the commit log. A pointer to upstream
discussion about it would be a bonus.

Can you respoin the patch, please?

> > Is it possible to just disable building tests at all? Or if not, can't
> > we just patch them out?
> We could...however upstream recommended not to do that as it can make
> tracing certain errors extremely difficult.

OK, but having a way to disable tests would still be good, because
basically, tests are useless on a product.

Regards,
Yann E. MORIN.

> >
> > Regards,
> > Yann E. MORIN.
> >
> > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > > ---
> > >  package/weston/weston.mk | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/package/weston/weston.mk b/package/weston/weston.mk
> > > index 8afe4bbab4..abafb3a6d9 100644
> > > --- a/package/weston/weston.mk
> > > +++ b/package/weston/weston.mk
> > > @@ -19,6 +19,8 @@ WESTON_CONF_OPTS = \
> > >       -Dcolor-management-colord=false \
> > >       -Dremoting=false
> > >
> > > +WESTON_CFLAGS="$(TARGET_CFLAGS) -UNDEBUG"
> > > +
> > >  # Uses VIDIOC_EXPBUF, only available from 3.8+
> > >  ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8),y)
> > >  WESTON_CONF_OPTS += -Dsimple-clients=dmabuf-v4l
> > > --
> > > 2.25.1
> > >
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot at busybox.net
> > > http://lists.busybox.net/mailman/listinfo/buildroot
> >
> > --
> > .-----------------.--------------------.------------------.--------------------.
> > |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> > | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> > | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> > '------------------------------^-------^------------------^--------------------'

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-06-16 20:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15  0:55 [Buildroot] [PATCH 1/1] package/weston: disable -NDEBUG James Hilliard
2021-06-16 19:22 ` Yann E. MORIN
2021-06-16 19:48   ` James Hilliard
2021-06-16 20:09     ` Yann E. MORIN [this message]
2021-06-16 20:20       ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210616200903.GS2610983@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox