From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Fri, 25 Jun 2021 11:27:04 +0200 Subject: [Buildroot] [PATCH 10/15] package/pkg-generic.mk: Move python fixup to generic package infrastructure In-Reply-To: <20210625102224.0da0e727@fedora> References: <20210621141130.48654-1-herve.codina@bootlin.com> <20210621141130.48654-11-herve.codina@bootlin.com> <20210622210103.GN44262@scaer> <20210625102224.0da0e727@fedora> Message-ID: <20210625092704.GJ2852@scaer> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Herv?, All, On 2021-06-25 10:22 +0200, Herve Codina spake thusly: > On Tue, 22 Jun 2021 23:01:03 +0200 > "Yann E. MORIN" wrote: > > So, earlier in the series, you introduced _PER_PACKAGE_TWEAK_HOOKS (or > > whatever the name it will eventually bear), stating that infras could > > set it, but here you are not taking the chance to demonstrate this, > > and instead you are inserting the python fixups in an ad-hoc way. > > > > Which also illustrates that the libtool fixups should be converted to > > the _PER_PACKAGE_TWEAK_HOOKS, probably... > Yes that's perfectly true. > > But do you think we need it right now in this patch series. > I really would prefer to keep it as it is for this patch series. > > The series is already quite complex and I think that converting > libtool and python fixups to PER_PACKAGE_TWEAK_HOOKS (or other name) > can be done afterward. I am always a bit wary about the "cleanup can be done in a later pass" excuse, because that later pass almost never manifests. But still, the issue is real, and we better have a solution rather than nothing, and we better have it earlier rather than later. So yes, keep things as they are. Regards, Yann E. MORIN, first-shoted in the morning! -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'