Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/at: bump versinon to 3.2.2
Date: Sat, 3 Jul 2021 22:12:23 +0200	[thread overview]
Message-ID: <20210703221223.4194738d@windsurf> (raw)
In-Reply-To: <20210703221053.590544d9@windsurf>

Hello,

Sorry, sent too quickly.

On Sat, 3 Jul 2021 22:10:53 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> >  Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> >  Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > +[Vincent: tweak the patch for the new version]
> > +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > +[Giulio: rebase to version 3.2.2 and modify IROOT/DESTDIR compability]  
> 
> The author of a commit (i.e the From: line) should always match the *first* Signed-off-by-line.
> 
> > -[PATCH]: Makefile.in: fix make install for non-root, don't strip
> > +From daae0a5a26ad78c05adb0eb1fc6cad1896e3766a Mon Sep 17 00:00:00 2001
> > +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > +Date: Mon, 21 Jun 2021 19:33:23 +0200
> > +Subject: [PATCH] Makefile.in: fix make install for non-root, don't strip

We have the same situation here: please keep the authorship.

Actually, perhaps you should do a preliminary patch that converts all
patches in package/at/ to be Git formatted patches, drop the 5/5 in
package/at/0001-Makefile.in-replace-IROOT-by-DESTDIR.patch, and then
have a patch doing the version bump.

Also minor nit in the commit title: versinon => version.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2021-07-03 20:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 17:44 [Buildroot] [PATCH] package/at: bump versinon to 3.2.2 Giulio Benetti
2021-07-03 20:10 ` Thomas Petazzoni
2021-07-03 20:12   ` Thomas Petazzoni [this message]
2021-07-23 20:08     ` [Buildroot] [PATCH 0/2] package/at: bump version Giulio Benetti
2021-07-23 20:08       ` [Buildroot] [PATCH 1/2] package/at: convert local patches to git format Giulio Benetti
2021-07-23 20:08       ` [Buildroot] [PATCH 2/2] package/at: bump version to 3.2.2 Giulio Benetti
2021-07-25 13:10       ` [Buildroot] [PATCH 0/2] package/at: bump version Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210703221223.4194738d@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox