From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/casync: undefine NDEBUG
Date: Sun, 4 Jul 2021 21:55:09 +0200 [thread overview]
Message-ID: <20210704195509.GH2521@scaer> (raw)
In-Reply-To: <54a8f6820a221cc3ba2446fedfd57743f742550f.1624512487.git.baruch@tkos.co.il>
Baruch, All,
On 2021-06-24 08:28 +0300, Baruch Siach spake thusly:
> The casync code relies on assert() calls being non-empty. Undefine
> NDEBUG to override BR2_ENABLE_RUNTIME_DEBUG not being set.
>
> Fixes:
> http://autobuild.buildroot.net/results/4c69f45a41462564382f667f5e97b78b49c97759/
> http://autobuild.buildroot.net/results/778a94f63c8e9f805badb5c8ff040dcfc5c193e7/
> http://autobuild.buildroot.net/results/d4c23639747dafcded4e28602ccbe48d102c385b/
>
> Cc: Yair Ben Avraham <yairba@protonmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
We are now no longer setting NDEBUG in the infra; see a1c7cff1a081.
So this patch is no longer needed; I've marked it as rejected.
Thanks!
Regards,
Yann E. MORIN.
> ---
> package/casync/casync.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/casync/casync.mk b/package/casync/casync.mk
> index d74cb1bfe85d..e161c7bbc6d3 100644
> --- a/package/casync/casync.mk
> +++ b/package/casync/casync.mk
> @@ -12,6 +12,9 @@ CASYNC_DEPENDENCIES = acl libcurl openssl
>
> CASYNC_CONF_OPTS = -Dman=false -Doss-fuzz=false -Dllvm-fuzz=false
>
> +# Code relies on assert(false) calls
> +CASYNC_CFLAGS = $(TARGET_CFLAGS) -UNDEBUG
> +
> ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
> CASYNC_DEPENDENCIES += bash-completion
> # The default path is correct, leave it as-is
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2021-07-04 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 5:28 [Buildroot] [PATCH] package/casync: undefine NDEBUG Baruch Siach
2021-07-04 19:55 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210704195509.GH2521@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox