Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/tor: unset the NDEBUG flag
Date: Sun, 4 Jul 2021 21:55:35 +0200	[thread overview]
Message-ID: <20210704195535.GI2521@scaer> (raw)
In-Reply-To: <20210620162030.1149816-1-bernd.kuhls@t-online.de>

Bernd, All,

On 2021-06-20 18:20 +0200, Bernd Kuhls spake thusly:
> For details see:
> https://gitlab.torproject.org/tpo/core/tor/-/blob/main/src/lib/log/util_bug.h#L56
> 
> Fixes:
> http://autobuild.buildroot.net/results/aab/aabc7fd3093b1a7f08de8d06a1875eb5d231be4c/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

We are now no longer setting NDEBUG in the infra; see a1c7cff1a081.

So this patch is no longer needed; I've marked it as rejected.

Thanks!

Regards,
Yann E. MORIN.

> ---
>  package/tor/tor.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/tor/tor.mk b/package/tor/tor.mk
> index e0db278fb9..fca272f836 100644
> --- a/package/tor/tor.mk
> +++ b/package/tor/tor.mk
> @@ -62,6 +62,9 @@ endif
>  # uses gnu extensions
>  TOR_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
>  
> +# tor does not support building with NDEBUG enabled
> +TOR_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -UNDEBUG"
> +
>  ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
>  TOR_CONF_ENV += LIBS=-latomic
>  endif
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2021-07-04 19:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-20 16:20 [Buildroot] [PATCH 1/1] package/tor: unset the NDEBUG flag Bernd Kuhls
2021-07-04 19:55 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210704195535.GI2521@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox