Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/nfs-utils: needs uuid
Date: Fri, 16 Jul 2021 23:06:17 +0200	[thread overview]
Message-ID: <20210716230617.135b52e1@windsurf> (raw)
In-Reply-To: <20210716210106.342232-1-fontaine.fabrice@gmail.com>

On Fri, 16 Jul 2021 23:01:06 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Build of nfs-utils without uuid is broken since bump to version 2.5.4 in
> commit 0ce30de72fb303768c5865949b8ce9260d0c43f5 because of
> http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=c5528f40f9db5061e06dcf1f9b7fce5185b376c6

A bug should be reported upstream: the configure script should be
checking for the existence of libuuid, and not hardcode -luuid.

> -ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID)$(BR2_PACKAGE_UTIL_LINUX_LIBUUID),yy)
> +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y)
>  NFS_UTILS_CONF_OPTS += --enable-uuid

Why do they still have a --enable-uuid / --disable-uuid option if uuid
is now mandatory anyway ?

It feels like the change from upstream is not quite complete :-/

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2021-07-16 21:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 21:01 [Buildroot] [PATCH 1/1] package/nfs-utils: needs uuid Fabrice Fontaine
2021-07-16 21:06 ` Thomas Petazzoni [this message]
2021-07-16 21:23   ` Fabrice Fontaine
2021-07-17 18:38     ` Petr Vorel
2021-07-17 18:54     ` Petr Vorel
2021-07-18 10:21 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210716230617.135b52e1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox