Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2,1/1] package/memcached: disable tests
Date: Sun, 18 Jul 2021 12:35:45 +0200	[thread overview]
Message-ID: <20210718123545.0487d4bf@windsurf> (raw)
In-Reply-To: <20210619204648.388641-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Sat, 19 Jun 2021 22:46:48 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Disable tests to avoid the following build failure with -DNDEBUG which
> is raised since commit 5a8c50fe05afacc3cbe8e7347e238da9f242fab0
> 
> /home/giuliobenetti/autobuild/run/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/microblazeel-buildroot-linux-uclibc/9.3.0/../../../../microblazeel-buildroot-linux-uclibc/bin/ld: testapp.o: in function `cache_redzone_test':
> (.text+0x2f48): undefined reference to `cache_error'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/c4ddd86bd4b74ba4e4857ee38e3a95bb9b019093
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes V1 -> v2:
>  - Fix MEMCACHED_CONF_OPTS handling

Since -DNDEBUG is no longer passed following commit
a1c7cff1a081765c082c196bd9e6c1e72ceee797, this failure no longer
occurs. While disabling tests would still be useful, I don't think
carrying a non-upstream patch that requires autoreconf really makes
sense.

If you get the patch upstreamed, of course we should then be using
--disable-tests.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2021-07-18 10:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 20:46 [Buildroot] [PATCH v2,1/1] package/memcached: disable tests Fabrice Fontaine
2021-07-18 10:35 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210718123545.0487d4bf@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox