From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Alexey Neyman <stilor@att.net>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 2/2] package/qemu: filter out long make options
Date: Wed, 21 Jul 2021 22:15:01 +0200 [thread overview]
Message-ID: <20210721221501.4c14fcfd@windsurf> (raw)
In-Reply-To: <20210721194605.1552794-3-stilor@att.net>
Hello,
On Wed, 21 Jul 2021 12:46:05 -0700
Alexey Neyman <stilor@att.net> wrote:
> Since qemu started using ninja, they have the following fragment in the
> Makefile:
>
> MAKE.n = $(findstring n,$(firstword $(MAKEFLAGS)))
> NINJAFLAGS = ... $(if $(MAKE.n), -n) ...
>
> Buildroot's generated makefile in the O= directory invokes make in the
> base buildroot with --no-print-directory. However, make's placement of
> the --no-print-directory in MAKEFLAGS varies between the versions of
> the host make; make 4.3 places that at the end while make 3.82 places
> it at the beginning. As a result, if building on a system with an older
> host make, qemu's makefile invokes `ninja -n` which does not generate
> any outputs.
>
> To reproduce, on a CentOS 7 machine or docker image:
> mkdir /tmp/br-build && cd /tmp/br-build
> make -C ~/buildroot pc_x86_64_bios_defconfig O=`pwd`
> make menuconfig # Switch to glibc, enable "QEMU" and "QEMU tools"
> make all # Build succeeds
> find target -name qemu-img # No binary has been built
I'm not sure to grasp all the implications of this, but isn't this a
bug in Qemu's build machinery, that should be fixed in Qemu's Makefile
instead ?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-07-21 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210721194605.1552794-1-stilor.ref@att.net>
2021-07-21 19:46 ` [Buildroot] [PATCH 0/2] Fix qemu package build Alexey Neyman
2021-07-21 19:46 ` [Buildroot] [PATCH 1/2] package/qemu: do not use deprecated option Alexey Neyman
2021-07-24 20:41 ` Yann E. MORIN
2021-07-21 19:46 ` [Buildroot] [PATCH 2/2] package/qemu: filter out long make options Alexey Neyman
2021-07-21 20:15 ` Thomas Petazzoni [this message]
2021-07-21 22:18 ` Alexey Neyman
2021-07-23 22:26 ` Thomas Petazzoni
2021-08-07 19:15 ` [Buildroot] [PATCH] " Alexey Neyman
2021-08-07 21:01 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721221501.4c14fcfd@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
--cc=stilor@att.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox