Re: [Buildroot] [PATCH v2 1/4] package/polkit: bump version to 0.119 and use duktape

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

On Wed, 21 Jul 2021 14:45:15 -0700
Adam Duskett <aduskett@gmail.com> wrote:

> Unfortuantly, as of commit 3e1d61868fa8bfc586099302e931433270e5d17d, polkit
> requires mozjs >= 78, which means spidermonkey is too old. As such, this patch
> is larger than usual.
> 
> Spidermonkey has a few major issues:
>   - The source directory after compilation is enormous (2.7G!)
>   - The shared library is 24MB stripped!
>   - It requires python2 to build, which is EOLed, and Buildroot is working
>     towards removing. See: https://elinux.org/Buildroot:Python2Packages
> 
> Instead of going through the arduous task of updating Spidermonkey, there is a
> better solution: use duktape.
> 
> There has been a pending patch for over a year that incorporates duktape as an
> optional backend for polkit found here:
> https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/35
> 
> As Thomas Petazzoni put it:
>   "As I am subscribed to notifications on this merge request, I have been
>   following the intermittent discussions taking place on this topic.
>   And indeed, discussions have been sparse, and the polkit maintainer reaction
>   has not been very supportive. It even feels like they are trying to find
>   every possible argument or small issue not to merge the duktape integration."
> 
> Many people have come out to support using duktape, and many users, including
> myself, have used polkit with duktape for as long as the above merge request has
> been around without issues; merging in the above merge request is an acceptable
> exception to the typical Buildroot package policies.
> 
> As Thomas also suggested, I have forked polkit on Github
> (https://github.com/aduskett/polkit-duktape), with the above duktape
> merge request applied, and a release made with the same tag as upstream (0.119).
> 
> I refrained from also adding 0001-make-netgroup-support-optional.patch as it is
> outside of the scope of why the fork exists.
> 
> Changes:
>   - refactor 0001-make-netgroup-support-optional.patch to work with 0.119 and
>     duktape.
>   - Remove upstream incorporated 0002-jsauthority-memleak.patch
>   - Remove upstream 0003-polkit-0.116-pkttyagent-sigttou-bg-job.patch
>   - Remove any trace of spidermonkey from polkit, udisks, and systemd-polkit
>   - Add duktape as a dependency of polkit
>   - Change POLKIT_SITE to the above polkit-duktape GitHub repository.
> 
> Signed-off-by: Adam Duskett <aduskett@gmail.com>

Thanks a lot for this new iteration, I have applied the entire series
to master. Thanks for this work, it's really great to have that in
Buildroot now.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot