From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "José Pekkarinen" <jose.pekkarinen@unikie.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH] Fix restorecond startup for sysvinit builds
Date: Sat, 24 Jul 2021 23:36:27 +0200 [thread overview]
Message-ID: <20210724233627.25e8ab13@windsurf> (raw)
In-Reply-To: <20210723124754.46568-1-jose.pekkarinen@unikie.com>
On Fri, 23 Jul 2021 15:47:54 +0300
José Pekkarinen <jose.pekkarinen@unikie.com> wrote:
> Currently restorecond init script sources the
> file /etc/rc.d/init.d/functions, that in some
> init systems, like sysvinit, may not be available,
> however, it doesn't actually uses any function
> from it.
>
> Also, the init script uses daemon, that is not
> marked as a dependency. So this patches adds its
> dependency to guarantee it's present in the build.
>
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
Thanks for this patch. However, if we are going to use our own init
script for restorecond, it should follow our "model" for init scripts,
package/busybox/S01syslogd. This means it should use start-stop-daemon,
instead of daemon, if possible.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-07-24 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 12:47 [Buildroot] [PATCH] Fix restorecond startup for sysvinit builds José Pekkarinen
2021-07-23 14:42 ` Baruch Siach
2021-07-26 5:06 ` José Pekkarinen
2021-07-24 21:36 ` Thomas Petazzoni [this message]
2021-07-26 5:29 ` José Pekkarinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210724233627.25e8ab13@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
--cc=jose.pekkarinen@unikie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox