From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Michael Nosthoff <buildroot@heine.tech>,
Marcin Bis <marcin@bis.org.pl>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/bluez5_utils: make a single option for avrcp and a2dp
Date: Tue, 27 Jul 2021 09:43:20 +0200 [thread overview]
Message-ID: <20210727094320.2ad01290@windsurf> (raw)
In-Reply-To: <20210727072523.2273052-1-fontaine.fabrice@gmail.com>
On Tue, 27 Jul 2021 09:25:23 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Build of avrcp without a2dp is broken since commit
> fb9fc969d91f69851b4c70dba512b607e52bda7b:
>
> /home/buildroot/autobuild/run/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/x86_64-buildroot-linux-uclibc/9.3.0/../../../../x86_64-buildroot-linux-uclibc/bin/ld: profiles/audio/bluetoothd-avrcp.o: in function `avrcp_handle_set_volume':
> avrcp.c:(.text+0x9c4): undefined reference to `media_transport_update_device_volume'
>
> However, build of a2dp without avrcp is also broken:
>
> /data/buildroot-autobuilder/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/riscv32-buildroot-linux-gnu/10.2.0/../../../../riscv32-buildroot-linux-gnu/bin/ld: profiles/audio/bluetoothd-media.o: in function `.L50':
> media.c:(.text+0x508): undefined reference to `avrcp_unregister_player'
> /data/buildroot-autobuilder/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/riscv32-buildroot-linux-gnu/10.2.0/../../../../riscv32-buildroot-linux-gnu/bin/ld: profiles/audio/bluetoothd-media.o: in function `match_endpoint_by_path':
> media.c:(.text+0x824): undefined reference to `avrcp_register_player'
>
> Fixes:
> - http://autobuild.buildroot.org/results/d54cdfc03212fff772a863d1bc8afd3cfb605831
> - http://autobuild.buildroot.org/results/64d75af986a4d6e9c5a176efb6e22046f4d82350
>
> So make a single audio option for a2dp and avrcp
Shouldn't this be reported as bug to upstream bluez ? If they have
separate options, they should work independently from each other.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-07-27 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 7:25 [Buildroot] [PATCH 1/1] package/bluez5_utils: make a single option for avrcp and a2dp Fabrice Fontaine
2021-07-27 7:43 ` Thomas Petazzoni [this message]
2021-07-27 8:12 ` Michael Nosthoff via buildroot
2021-07-27 8:03 ` Michael Nosthoff via buildroot
2021-07-28 19:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727094320.2ad01290@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=buildroot@heine.tech \
--cc=fontaine.fabrice@gmail.com \
--cc=marcin@bis.org.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox