From: Peter Seiderer <ps.report@gmx.net>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC v1 1/2] package/iptables: add option to enabel libipq build
Date: Tue, 27 Jul 2021 22:52:51 +0200 [thread overview]
Message-ID: <20210727225251.19b7a798@gmx.net> (raw)
In-Reply-To: <20210725215756.059e125f@windsurf>
Hello Thomas,
On Sun, 25 Jul 2021 21:57:56 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> On Sun, 20 Jun 2021 22:56:06 +0200
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > - add option to enable libipq build
> > - as libipq.h includes linux/netfilter_ipv4/ip_queue.h install (not
> > provided by modern kernels otherwise?)
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> Is it really a good idea to add an option for this library?
>
> Debian dropped installing libipq 5 years ago, as this library is
> deprecated:
>
> https://salsa.debian.org/pkg-netfilter-team/pkg-iptables/-/commit/bf21537d27ee72cc69ca0883059b315ceaf9737d
>
> Also in 2012, iptables developers said they would keep this library for
> 1.5-2 years:
>
> https://git.netfilter.org/iptables/commit/?id=a624e0a1b2d075253b599ababd4ea1351ef42b2a
Did the patch as part of porting an custom (very ancient ubuntu based) project
to up-to-date buildroot, but hope to get rid of all legacy dependencies on the
long run..., no problem with dropping this patch...
>
> But then, when I look at the nrlsmf source code, I don't see any
> reference to libipq or ip_queue.h. Am I missing something ?
File smf-1.1b2/protolib/unix/linuxDetour.cpp:
15 #include <linux/netfilter_ipv4/ip_queue.h>
Mhhh, maybe I mistake it because of the ip_queue.h file found in libipq...
No problem dropping this patch, see above ;-)
Regards,
Peter
>
> Thanks,
>
> Thomas
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-07-27 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-20 20:56 [Buildroot] [RFC v1 1/2] package/iptables: add option to enabel libipq build Peter Seiderer
2021-06-20 20:56 ` [Buildroot] [RFC v1 2/2] package/nrlsmf: new package Peter Seiderer
2021-07-25 19:57 ` [Buildroot] [RFC v1 1/2] package/iptables: add option to enabel libipq build Thomas Petazzoni
2021-07-27 20:52 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727225251.19b7a798@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox