Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/tpm2-tools: disable on uClibc, due to c16rtomb()
Date: Sat, 31 Jul 2021 13:14:13 +0200	[thread overview]
Message-ID: <20210731111413.GK3189549@scaer> (raw)
In-Reply-To: <20210731101604.2080629-1-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2021-07-31 12:16 +0200, Thomas Petazzoni spake thusly:
> Since upstream commit eca77c1419617a8e2d6d8008bac716878b0c27ca, the
> c16rtomb() wide-char function is used by tpm2-tools, but this function
> is not implemented by uClibc.
> 
> This commit first appeared in tpm-tools 4.2, and therefore the bump
> from version 4.1.2 to 4.3.2 in commit
> 91aa6efa8588bf7617cc4a640eb55052b524ceb7 causes a build failure on
> uClibc configurations.
> 
> An issue was reported at
> https://github.55860.com/tpm2-software/tpm2-tools/issues/2785, but in
> the mean time, we disable tpm2-tools on uClibc configurations.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/f91950b1e5620844bb04a65252d0836da736965d/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/tpm2-tools/Config.in | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/package/tpm2-tools/Config.in b/package/tpm2-tools/Config.in
> index cbdfeb6801..3be947648f 100644
> --- a/package/tpm2-tools/Config.in
> +++ b/package/tpm2-tools/Config.in
> @@ -2,6 +2,8 @@ config BR2_PACKAGE_TPM2_TOOLS
>  	bool "tpm2-tools"
>  	depends on !BR2_STATIC_LIBS # tpm2-tss
>  	depends on BR2_USE_WCHAR
> +	# c16rtomb() not implemented in uClibc
> +	depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL
>  	select BR2_PACKAGE_LIBCURL
>  	select BR2_PACKAGE_OPENSSL
>  	select BR2_PACKAGE_TPM2_TSS
> @@ -21,5 +23,6 @@ config BR2_PACKAGE_TPM2_TOOLS
>  
>  	  https://github.com/tpm2-software/tpm2-tools
>  
> -comment "tpm2-tools needs a toolchain w/ dynamic library, wchar"
> -	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR
> +comment "tpm2-tools needs a glibc or musl toolchain w/ dynamic library, wchar"
> +	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || \
> +		!(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL)
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

      reply	other threads:[~2021-07-31 11:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 10:16 [Buildroot] [PATCH] package/tpm2-tools: disable on uClibc, due to c16rtomb() Thomas Petazzoni
2021-07-31 11:14 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210731111413.GK3189549@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox