Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Francois Perrad <fperrad@gmail.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH] package/lua-lunix: fix build with recent gcc
Date: Sun, 1 Aug 2021 12:06:34 +0200	[thread overview]
Message-ID: <20210801120634.245316d7@windsurf> (raw)
In-Reply-To: <20210801095734.3213451-1-francois.perrad@gadz.org>

Hello François,

Thanks for the patch! However, there are a few formatting issues, see
below.

On Sun,  1 Aug 2021 11:57:34 +0200
Francois Perrad <fperrad@gmail.com> wrote:

> see http://autobuild.buildroot.net/results/749a11d5289c6fec3b2f236b9073fc1ab730d090/

This should be:

Fixes:

  http://autobuild.buildroot.net/results/749a11d5289c6fec3b2f236b9073fc1ab730d090/

The fact that there is the "Fixes" word ensures that patchwork
identifies it as a patch that fixes something.

> diff --git a/package/lua-lunix/0003-use-linux-sysctl-instead-of-deprecated-sys-sysctl.patch b/package/lua-lunix/0003-use-linux-sysctl-instead-of-deprecated-sys-sysctl.patch
> new file mode 100644
> index 000000000..e2369bdfb
> --- /dev/null
> +++ b/package/lua-lunix/0003-use-linux-sysctl-instead-of-deprecated-sys-sysctl.patch
> @@ -0,0 +1,31 @@
> +Fetched from https://github.com/wahern/lunix/pull/18

This should go...

> +
> +From 99b02b08d3f1a53e58b558b9f2250225e569a550 Mon Sep 17 00:00:00 2001
> +From: Tiago Seco <tiago@seco.ws>
> +Date: Sun, 20 Jun 2021 11:20:23 +0200
> +Subject: [PATCH] use <linux/sysctl.h> instead of deprectaed <sys/sysctl.h> for
> + linux systems
> +

... here. Otherwise you break the patch which cannot be applied with
"git am" anymore.

Also, you need to add your Signed-off-by line in the patch. Note that
this particular issue is reported by "make check-package".

Could you adjust those minor details and send an updated version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

      reply	other threads:[~2021-08-01 10:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01  9:57 [Buildroot] [PATCH] package/lua-lunix: fix build with recent gcc Francois Perrad
2021-08-01 10:06 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210801120634.245316d7@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    --cc=fperrad@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox