From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
Buildroot List <buildroot@buildroot.org>
Cc: Frank Vanbever <frank.vanbever@essensium.com>
Subject: Re: [Buildroot] [PATCH v2] package/libmodsecurity: fix build with libmaxminddb
Date: Mon, 2 Aug 2021 22:23:58 +0200 [thread overview]
Message-ID: <20210802222358.2e7d14b0@windsurf> (raw)
In-Reply-To: <20210801215159.2435224-1-thomas.petazzoni@bootlin.com>
On Sun, 1 Aug 2021 23:51:58 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> Build with libmaxminddb is broken since bump to version 3.0.5 in commit
> 464d0be380c84ac7c3f1684e49153c3868280d7e because of
> https://github.com/SpiderLabs/ModSecurity/commit/785958f9b5089b918c7d054cbcc2fe4a3c7b3788
>
> So revert this commit until upstream answer to comment to
> https://github.com/SpiderLabs/ModSecurity/issues/2131
>
> Reverting this commit requires autoreconfiguring, which itself causes
> lots of warnings as configure.ac queries git to know the version of
> various parts of libmodsecurity. However, it turns out that those
> versions are only used to be displayed in the output of the configure
> script, which is quite useless. The only one that is referenced
> elsewhere is LIBINJECTION_VERSION, but it's in fact a different thing:
> it is defined by others/libinjection/src/libinjection_sqli.c.
>
> The only variable that was AC_SUBST() and therefore visible elsewhere
> was MSC_GIT_VERSION, but it is not used anywhere in the code base,
> except in the configure script itself.
>
> Note that one patch is 0001 and the other 0003, because there was
> already a 0002 patch.
>
> Fixes:
> - http://autobuild.buildroot.org/results/4c639fd967faa06f8ae362bacd38f3409c47267c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> ...-drop-usage-of-git-at-configure-time.patch | 79 +++++++++++++++++++
> ...Revert-Fix-maxminddb-link-on-FreeBSD.patch | 28 +++++++
> package/libmodsecurity/libmodsecurity.mk | 2 +
> 3 files changed, 109 insertions(+)
> create mode 100644 package/libmodsecurity/0001-configure.ac-drop-usage-of-git-at-configure-time.patch
> create mode 100644 package/libmodsecurity/0003-Revert-Fix-maxminddb-link-on-FreeBSD.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-02 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 21:51 [Buildroot] [PATCH v2] package/libmodsecurity: fix build with libmaxminddb Thomas Petazzoni
2021-08-02 20:23 ` Thomas Petazzoni [this message]
2021-08-08 7:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802222358.2e7d14b0@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=frank.vanbever@essensium.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox