From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6111C4338F for ; Tue, 3 Aug 2021 06:57:56 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29A4760F9C for ; Tue, 3 Aug 2021 06:57:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 29A4760F9C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=busybox.net Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DC8A5606C4; Tue, 3 Aug 2021 06:57:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jci9aldQGu0z; Tue, 3 Aug 2021 06:57:55 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 2A5776060B; Tue, 3 Aug 2021 06:57:54 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 405C81BF35D for ; Tue, 3 Aug 2021 06:57:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 376564016F for ; Tue, 3 Aug 2021 06:57:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VY5lnYxahvYY for ; Tue, 3 Aug 2021 06:57:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by smtp2.osuosl.org (Postfix) with ESMTPS id BD587400B9 for ; Tue, 3 Aug 2021 06:57:50 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 1C5D920005; Tue, 3 Aug 2021 06:57:46 +0000 (UTC) Date: Tue, 3 Aug 2021 08:57:45 +0200 From: Thomas Petazzoni To: Petr Vorel Message-ID: <20210803085745.6c7e4ce2@windsurf> In-Reply-To: References: <20210802172116.10073-1-petr.vorel@gmail.com> <2A61C2B3-401F-459C-9DD1-727E041D1A20@benettiengineering.com> <20210802221341.760ffbf0@windsurf> Organization: Bootlin X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 1/1] package/nfs-utils: Backport yet another printf fix X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Giulio Benetti , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" On Tue, 3 Aug 2021 00:06:46 +0200 Petr Vorel wrote: > I believe all 3 patches (2 already merged + this one) should fix the problem. > But I was not able to verify it, because ./utils/test-pkg didn't catch even > this error (I tested all available toolchains), IMHO -Werror=format=2 and other > -Werror are probably only on http://autobuild.buildroot.net/ (not in Buildroot > config for users). It'd be great if ./utils/test-pkg had the same CFLAGS. > Or have I (again) overlooked something? No, the autobuilders don't do anything specific with -Werror CFLAGS. The configurations tested by the autobuilders are generated by utils/genrandconfig in the Buildroot tree. Besides the obvious package randomization, there is some randomization of "global" options: # Per-package folder if randint(0, 15) == 0: configlines.append("BR2_PER_PACKAGE_DIRECTORIES=y\n") # Amend the configuration with a few things. if randint(0, 20) == 0: configlines.append("BR2_ENABLE_DEBUG=y\n") if randint(0, 20) == 0: configlines.append("BR2_ENABLE_RUNTIME_DEBUG=y\n") if randint(0, 1) == 0: configlines.append("BR2_INIT_BUSYBOX=y\n") elif randint(0, 15) == 0: configlines.append("BR2_INIT_SYSTEMD=y\n") elif randint(0, 10) == 0: configlines.append("BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y\n") if randint(0, 20) == 0: configlines.append("BR2_STATIC_LIBS=y\n") if randint(0, 20) == 0: configlines.append("BR2_PACKAGE_PYTHON_PY_ONLY=y\n") if randint(0, 5) == 0: configlines.append("BR2_OPTIMIZE_2=y\n") if randint(0, 4) == 0: configlines.append("BR2_SYSTEM_ENABLE_NLS=y\n") if randint(0, 4) == 0: configlines.append("BR2_FORTIFY_SOURCE_2=y\n") For example, did you test with BR2_FORTIFY_SOURCE_2=y ? Could you point me to the autobuilder failure that you had, but was not able to reproduce with test-pkg ? We should be able to point out the difference. The thing is that test-pkg cannot test all possibilities, it would take way too much time. Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot