From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Pascal de Bruijn <p.debruijn@unilogic.nl>
Cc: "aduskett@gmail.com" <aduskett@gmail.com>,
"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 3/3] package/php: enable opcache jit
Date: Thu, 5 Aug 2021 16:10:20 +0200 [thread overview]
Message-ID: <20210805161020.5fde871c@windsurf> (raw)
In-Reply-To: <AM0PR07MB39876E0E73FD0E7059D1D5CB9DF29@AM0PR07MB3987.eurprd07.prod.outlook.com>
Hello,
On Thu, 5 Aug 2021 14:04:49 +0000
Pascal de Bruijn <p.debruijn@unilogic.nl> wrote:
> In ed355dec (PATCH 2/3) the following line is what makes opcache actually work:
What is ed355dec ? I don't have any commit with that reference in
Buildroot. If it's the reference of the commit of PATCH 2/3 in your
Buildroot Git repository, then it doesn't make sense to reference it,
as this commit won't have the same hash when we'll apply your patch,
i.e ed355dec means nothing expect just to you locally.
> PHP_CHECK_LIBRARY(rt, shm_unlink, [PHP_ADD_LIBRARY(rt,1,OPCACHE_SHARED_LIBADD)])
And what is this doing ? Again shm_unlink() is no longer in librt, it's
in libc since glibc 2.17 (if I remember correctly).
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-05 14:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 8:53 [Buildroot] [PATCH 1/3] package/php: remove ineffective opcache patch Pascal de Bruijn
2021-08-05 8:53 ` [Buildroot] [PATCH 2/3] package/php: opcache link against librt for shm_unlink Pascal de Bruijn
2021-08-05 16:39 ` Arnout Vandecappelle
2021-08-05 8:53 ` [Buildroot] [PATCH 3/3] package/php: enable opcache jit Pascal de Bruijn
2021-08-05 13:31 ` Thomas Petazzoni
2021-08-05 13:53 ` Pascal de Bruijn
2021-08-05 14:01 ` Thomas Petazzoni
2021-08-05 14:04 ` Pascal de Bruijn
2021-08-05 14:10 ` Thomas Petazzoni [this message]
2021-08-05 14:47 ` Pascal de Bruijn
2021-08-05 16:27 ` Arnout Vandecappelle
2021-08-05 16:41 ` Arnout Vandecappelle
2021-08-05 16:44 ` [Buildroot] [PATCH 1/3] package/php: remove ineffective opcache patch Arnout Vandecappelle
2021-08-10 19:01 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805161020.5fde871c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=aduskett@gmail.com \
--cc=buildroot@buildroot.org \
--cc=p.debruijn@unilogic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox