Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
	Romain Naour <romain.naour@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/mesa3d: x11 needs EGL, GLX or a vulkan driver
Date: Thu, 5 Aug 2021 21:54:50 +0200	[thread overview]
Message-ID: <20210805215450.78d1bc33@windsurf> (raw)
In-Reply-To: <20191229131453.327907-2-fontaine.fabrice@gmail.com>

On Sun, 29 Dec 2019 14:14:53 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> As specified in meson.build, x11 platform needs EGL, GLX or a vulkan
> driver:
> 
> if with_platform_x11
>   if with_any_vk or with_egl or (with_glx == 'dri' and with_dri_platform == 'drm')
>     pre_args += '-DHAVE_X11_PLATFORM'
>   endif
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e044609e603ca68695d842d08809fdcb35bc8127
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/mesa3d/Config.in | 1 +
>  1 file changed, 1 insertion(+)

It has been such a long time, and mesa3d has seen so many chnages
since, that I doubt this patch still makes sense in its current form.
Could you respin the patch if it still fixes an issue that exists
today? In fact, you never replied to the feedback I gave, see
https://patchwork.ozlabs.org/project/buildroot/patch/20191229131453.327907-2-fontaine.fabrice@gmail.com/.

So I'll mark the patch as Rejected for now, but don't hesitate to
respin if you think this patch is still needed, but taking into account
the questions I had raised.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  parent reply	other threads:[~2021-08-05 19:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-29 13:14 [Buildroot] [PATCH 1/2] package/mesa3d: XvMC needs x11 Fabrice Fontaine
2019-12-29 13:14 ` [Buildroot] [PATCH 2/2] package/mesa3d: x11 needs EGL, GLX or a vulkan driver Fabrice Fontaine
2020-09-15 19:05   ` Thomas Petazzoni
2021-08-05 19:54   ` Thomas Petazzoni [this message]
2020-09-15 18:50 ` [Buildroot] [PATCH 1/2] package/mesa3d: XvMC needs x11 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210805215450.78d1bc33@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox