From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 478B4C432BE for ; Fri, 6 Aug 2021 12:48:08 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF2CD61184 for ; Fri, 6 Aug 2021 12:48:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AF2CD61184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=busybox.net Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7E2A783BBB; Fri, 6 Aug 2021 12:48:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id etj23XdKX4C2; Fri, 6 Aug 2021 12:48:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id D181D83BB2; Fri, 6 Aug 2021 12:48:05 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 50A351BF37F for ; Fri, 6 Aug 2021 12:48:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 3F870405C5 for ; Fri, 6 Aug 2021 12:48:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CEMv9QUTH96O for ; Fri, 6 Aug 2021 12:48:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by smtp4.osuosl.org (Postfix) with ESMTPS id 1154140581 for ; Fri, 6 Aug 2021 12:48:02 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A0B1AFF80C; Fri, 6 Aug 2021 12:47:58 +0000 (UTC) Date: Fri, 6 Aug 2021 14:47:57 +0200 From: Thomas Petazzoni To: Mehmet Sami Tok Message-ID: <20210806144757.2f194d57@windsurf> In-Reply-To: References: <20200107123209.6608-1-mehmetsamitok@gmail.com> <20200107123209.6608-2-mehmetsamitok@gmail.com> <20210805220339.112d2451@windsurf> Organization: Bootlin X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 1/1] package/qt5: remove optimize by default on debug builds made with qmake X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Seiderer , Julien Corjon , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Hello Mehmet, On Fri, 6 Aug 2021 14:39:07 +0300 Mehmet Sami Tok wrote: > Thanks for the response. This is an old patch and I don't know if the > problem is still there. But the main point of this patch was not changing > flags of Qt package build. > When you want to use gcc toolchain and qmake generated by buildroot, It was > affecting your application builds. These flags directly passed to qt > toolchain and even if you want to build a debug build of any application, > it is built with -o2. So the problem is not occuring when root file system > is created, it appears when you want to build something else with toolchain > generated by buildroot. I see. Indeed in this case we might consider that we should obey to the particular flags you specify rather than the ones from the Buildroot configuration. However, unless I misread your patch, it removed optimization flags even for qmake packages built within Buildroot, which is not what we want. Best regards, Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot