Re: [Buildroot] [PATCH 1/1] package/qemu: disable vhost-user with uclibc-ng

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Romain Naour <romain.naour@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qemu: disable vhost-user with uclibc-ng
Date: Sat, 7 Aug 2021 10:24:37 +0200	[thread overview]
Message-ID: <20210807082437.GR27036@scaer> (raw)
In-Reply-To: <20210806211048.115264-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2021-08-06 23:10 +0200, Fabrice Fontaine spake thusly:
> Disable vhost-user on uclibc-ng as it raises build failures since bump
> to version 6.0.0 in commit 6b86c9335fc3ff381878156c6243454d4b688df9 and
> https://github.com/qemu/qemu/commit/810033be083040591fee2fc09f2f294670ed1930
> 
> The issue is that F_ADD_SEALS and F_SEAL_xxx variables are not defined on
> uclibc-ng (even if MFD_ALLOW_SEALING is defined) resulting in the
> following build failure:
> 
> ../subprojects/libvhost-user/libvhost-user.c:1637:22: error: 'F_ADD_SEALS' undeclared (first use in this function)
>  1637 |     ret = fcntl(*fd, F_ADD_SEALS, flags);
>       |                      ^~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/9f393539931b51191cf7128e5c618c2398fc86c1
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/qemu/qemu.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index b2a9420b21..1854aed201 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -201,6 +201,7 @@ define QEMU_CONFIGURE_CMDS
>  			--disable-capstone \
>  			--with-git-submodules=ignore \
>  			--disable-opengl \
> +			$(if $(BR2_TOOLCHAIN_USES_UCLIBC),--disable-vhost-user,--enable-vhost-user) \

I've changed that to use a conditional block, like we use for all other
conditional options.

>  			--disable-vhost-user-blk-server \

I was wodnering whether we would have to do something about that, but
no. It's disabling the option, and the configure script checks it only
if vhost-user is set.

However, there's also vhost-user-fs that we do not handle. The default
is disabled, so that's still OK...

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  			--disable-virtiofsd \
>  			--disable-tests \
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot