From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/ffmpeg: add -latomic to libavformat.pc
Date: Sat, 7 Aug 2021 19:07:00 +0200 [thread overview]
Message-ID: <20210807170700.GD27036@scaer> (raw)
In-Reply-To: <CAPi7W82H4T-zqU4Q5u8L0LVESd_NC7i9egDYhA0F3aw=rd4hCA@mail.gmail.com>
Fabrice, All,
On 2021-08-07 17:01 +0200, Fabrice Fontaine spake thusly:
> Le sam. 7 août 2021 à 11:50, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
> > On 2021-08-06 16:36 +0200, Fabrice Fontaine spake thusly:
> > > -latomic was added to extralibs to fix static build of ffmpeg in commit
> > > fc8798197b57488a852e2c14b4677b5eb0114a0b. However, extralibs is not
> > > added to libavformat.pc resulting in the following static build failure
[--SNIP--]
> > > So add a patch to add extralibs (and so -latomic) to libavformat.pc
[--SNIP--]
> > > +diff --git a/configure b/configure
> > > +index 0bb3a7cf2b..cb366c3ba6 100755
> > > +--- a/configure
> > > ++++ b/configure
> > > +@@ -7604,7 +7604,7 @@ LIBPREF=${LIBPREF}
> > > + LIBSUF=${LIBSUF}
> > > + extralibs_avutil="$avutil_extralibs"
> > > + extralibs_avcodec="$avcodec_extralibs"
> > > +-extralibs_avformat="$avformat_extralibs"
> > > ++extralibs_avformat="$avformat_extralibs $extralibs"
> > > + extralibs_avdevice="$avdevice_extralibs"
> > > + extralibs_avfilter="$avfilter_extralibs"
> > > + extralibs_avresample="$avresample_extralibs"
> >
> > Shouldn't we also add $extralibs to all, instead of just avformat?
> I don't know if all ffmpeg libraries depend on libatomic so I only
> updated avformat as it is enough to fix the build failure but I can
> update all of them if you think it's better.
Thing is, $extralibs is used in the link of all ffmpeg libraries, so it
would make sense it is also added to all the per-library extralibs.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-07 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 14:36 [Buildroot] [PATCH 1/1] package/ffmpeg: add -latomic to libavformat.pc Fabrice Fontaine
2021-08-07 9:50 ` Yann E. MORIN
2021-08-07 15:01 ` Fabrice Fontaine
2021-08-07 17:07 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210807170700.GD27036@scaer \
--to=yann.morin.1998@free.fr \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=mahyar.koshkouei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox