Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/guile: fix build on riscv32
Date: Sat, 7 Aug 2021 19:12:49 +0200	[thread overview]
Message-ID: <20210807171249.GE27036@scaer> (raw)
In-Reply-To: <CAPi7W81cMuZYxxLKYW22N6-htbfCaXYkHoJCmnV-izpjCvSMew@mail.gmail.com>

Fabrice, All,

On 2021-08-07 17:08 +0200, Fabrice Fontaine spake thusly:
> Le sam. 7 août 2021 à 10:53, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
> > On 2021-08-06 20:44 +0200, Fabrice Fontaine spake thusly:
> > > Fix the following build failure on riscv32:
> > > system/base/target.scm:132:16: In procedure triplet-pointer-size:
> > > unknown CPU word size "riscv32"
[--SNIP--]
> > > ++          ((string-match "^riscv.*" cpu) 8)
> > Are you sure that a 32-bit CPU will have 8-byte wide words? I would
> > have naturrally expected them to be just 4-byte wide...
> As I'm not an expert in riscv, I searched on wikipedia and here is an
> extract of https://en.wikipedia.org/wiki/RISC-V:
> "Memory is addressed as 8-bit bytes, with words being in little-endian order"
> It would be great if a riscv expert could confirm or not this information.

So, yes. Re-read that carefully:

  - 8-bit bytes. I.e. a byte is 8 bits

  - words being in little-endian order

That indeed says nothing about word size in bytes (not in bits!).

I might be wrong, but on a 32-bit arch, words are always 4-bytes wides,
i.e. 32 bits, while on a 64-bit architecutre, words are 8-byte wide,
i.e. 64 bits.

So, I would wager that riscv32 has 4-byte wide, ie 32-bit wide, words.

Regards,
Yann E. MORIN.

> > If htis is indeed the case, then please explain that in the patch commit
> > log...
> >
> > Regards,
> > Yann E. MORIN.
> >
> > > +           (else (error "unknown CPU word size" cpu)))))
> > > +
> > > + (define (triplet-cpu t)
> > > +--
> > > +2.30.2
> > > +
> > > --
> > > 2.30.2
> > >
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot@busybox.net
> > > http://lists.busybox.net/mailman/listinfo/buildroot
> >
> > --
> > .-----------------.--------------------.------------------.--------------------.
> > |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> > | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> > | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> > '------------------------------^-------^------------------^--------------------'
> Best Regards,
> 
> Fabrice

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-07 17:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06 18:44 [Buildroot] [PATCH 1/1] package/guile: fix build on riscv32 Fabrice Fontaine
2021-08-07  8:53 ` Yann E. MORIN
2021-08-07 15:08   ` Fabrice Fontaine
2021-08-07 17:12     ` Yann E. MORIN [this message]
2021-08-07 17:30       ` Fabrice Fontaine
2021-08-07 23:21   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210807171249.GE27036@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox