From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: Peter Seiderer <ps.report@gmx.net>,
Quentin Schulz <foss@0leil.net>,
Julien Corjon <corjon.j@ecagroup.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/qt5/qt5base: do not link against host libatomic when building host tools within qt5* target packages
Date: Sun, 8 Aug 2021 22:36:36 +0200 [thread overview]
Message-ID: <20210808223636.465b7c2f@windsurf> (raw)
In-Reply-To: <20210806143839.2905163-1-quentin.schulz@theobroma-systems.com>
On Fri, 6 Aug 2021 16:38:39 +0200
Quentin Schulz <quentin.schulz@theobroma-systems.com> wrote:
> qt5declarative builds qmltyperegistrar for the host as part of its build
> process.
> When building qt target packages (which is the case for qt5declarative),
> -spec devices/linux-buildroot-g++ is passed to qmake in QT5_QMAKE
> variable and this spec currently has -latomic in its LIBS.
>
> This -latomic makes it to the build of the host build of
> qmltyperegistrar which is not useful.
>
> This was discovered on Fedora 34 where libatomic is not pulled with gcc
> package, therefore was missing on the host machine.
>
> This makes sure that -latomic is not added for host build of qt
> packages.
>
> Fixes: 7d286be4f9 ("package/qt5base: link with -latomic when needed")
>
> Cc: Quentin Schulz <foss@0leil.net>
> Suggested-by: Arnout Vandecappelle <arnout@mind.be>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
> package/qt5/qt5base/qt5base.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-08 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 14:38 [Buildroot] [PATCH] package/qt5/qt5base: do not link against host libatomic when building host tools within qt5* target packages Quentin Schulz
2021-08-08 20:36 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210808223636.465b7c2f@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=corjon.j@ecagroup.com \
--cc=foss@0leil.net \
--cc=ps.report@gmx.net \
--cc=quentin.schulz@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox